From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51666C2D0DB for ; Fri, 24 Jan 2020 11:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2574F20663 for ; Fri, 24 Jan 2020 11:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863966; bh=FEz5wwYgE1K+I9svTO2hpZMPGr485rBFku3mYnXeNlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FqddFVq2fMVHFpZWSy1iTL03y8OFyDyDuRHCaw2/1SopeRFTD66v55E9CqgJmazDU fYRrYHoXSETLQPJZg1gOOp8MCFx0aoxuM0CZ/1HsSWR0Mrn8KAcTfIy2q7p/Bat5Xj 976fZr3TFFY2PCDNuGSuqoJgspqUWMvNQNh1qTh8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388328AbgAXLGE (ORCPT ); Fri, 24 Jan 2020 06:06:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:40668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732644AbgAXLGE (ORCPT ); Fri, 24 Jan 2020 06:06:04 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EEA120663; Fri, 24 Jan 2020 11:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863963; bh=FEz5wwYgE1K+I9svTO2hpZMPGr485rBFku3mYnXeNlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gZDYGFHf567w7wldtP4LCVpZ12RwkefOXKP2MtpOcuILsqGPkk5FvLIv6/M81xHLf /Q3TdLEO5P+XlBrMIsNWxIlWT/ctlCeS6vUnIjTSbIOZx7pOCwKY1V76brEYyn+ef4 FJ7fYoNTIfcJY1j6IgXiX9GmqTbrPuqar8XcLlJs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Lucas Stach , Sasha Levin Subject: [PATCH 4.19 133/639] drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump() Date: Fri, 24 Jan 2020 10:25:03 +0100 Message-Id: <20200124093103.939996199@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit f8261c376e7f8cb9024af5a6c54be540c7f9108e ] The etnaviv_gem_get_pages() never returns NULL. It returns error pointers on error. Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver") Signed-off-by: Dan Carpenter Signed-off-by: Lucas Stach Signed-off-by: Sasha Levin --- drivers/gpu/drm/etnaviv/etnaviv_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c index 468dff2f79040..9d839b4fd8f78 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c @@ -217,7 +217,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) mutex_lock(&obj->lock); pages = etnaviv_gem_get_pages(obj); mutex_unlock(&obj->lock); - if (pages) { + if (!IS_ERR(pages)) { int j; iter.hdr->data[0] = bomap - bomap_start; -- 2.20.1