From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62930C2D0DB for ; Fri, 24 Jan 2020 11:43:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26F98206D4 for ; Fri, 24 Jan 2020 11:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579866198; bh=7nPI0tt7j0JBxlx0n7ebAsqlu3UsN9J6K28FdVhwmn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=avJIIvmZCBBx5WfcbkhBvNJv202RGUGtf/YCmui3XIoOiTC8R38N1UGldzIHEAYkS sITWXZqmGmf+2mI/vG+puLYluRwwnOSS1nXGgQTTdZaQlMPiAFvYxKJla/ivZiVSIG 2VMGCe5xfD/aF6OZCoFrcT02DNVKKEqd5xkyDSik= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729133AbgAXLJ0 (ORCPT ); Fri, 24 Jan 2020 06:09:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:44994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730771AbgAXLJX (ORCPT ); Fri, 24 Jan 2020 06:09:23 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4313220708; Fri, 24 Jan 2020 11:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864162; bh=7nPI0tt7j0JBxlx0n7ebAsqlu3UsN9J6K28FdVhwmn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRiryMJAVUlNKzcxh+YafyJStps+3lVb3uvrqhz7tuLHWux1hJMkGDXlF5S2Xx2T7 0mGbf+bTQm1GOJM3TQ6TgbImavXgDyArqVwa7JA928bUDb5Lfveck2cdL4fCOAniUZ EMcri2ZmyTUSF05IkqOtvDCBC2wWXBSVg8KuBbog= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Lunn , Moritz Fischer , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 176/639] net: phy: fixed_phy: Fix fixed_phy not checking GPIO Date: Fri, 24 Jan 2020 10:25:46 +0100 Message-Id: <20200124093109.232533274@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Moritz Fischer [ Upstream commit 8f289805616e81f7c1690931aa8a586c76f4fa88 ] Fix fixed_phy not checking GPIO if no link_update callback is registered. In the original version all users registered a link_update callback so the issue was masked. Fixes: a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.") Reviewed-by: Andrew Lunn Signed-off-by: Moritz Fischer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/fixed_phy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 67b260877f305..59820164502eb 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -67,11 +67,11 @@ static int fixed_mdio_read(struct mii_bus *bus, int phy_addr, int reg_num) do { s = read_seqcount_begin(&fp->seqcount); /* Issue callback if user registered it. */ - if (fp->link_update) { + if (fp->link_update) fp->link_update(fp->phydev->attached_dev, &fp->status); - fixed_phy_update(fp); - } + /* Check the GPIO for change in status */ + fixed_phy_update(fp); state = fp->status; } while (read_seqcount_retry(&fp->seqcount, s)); -- 2.20.1