From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98330C2D0DB for ; Fri, 24 Jan 2020 11:37:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63390206F0 for ; Fri, 24 Jan 2020 11:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865869; bh=h+YsFhOrvxkG1rDExqndtKUWeCndh28lYygtKDg6LN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=k0SOvHwHk9pjezplO6cyDRx9QuKFxFzAnrpYhzstzvCiN6a752zDnKCasRod+auup x5/zi0PLt3yVis6nFYREK5vJTgfrdrs3zqmHYew4OH1hAkYpF30HYZVsnky4XIiN8u jHLQ3ry4QDpfpGwDCH1zSItDQuhvW4PlhAX/Rhn0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404283AbgAXLaq (ORCPT ); Fri, 24 Jan 2020 06:30:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:48688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404281AbgAXLaq (ORCPT ); Fri, 24 Jan 2020 06:30:46 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA1BD2075D; Fri, 24 Jan 2020 11:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865445; bh=h+YsFhOrvxkG1rDExqndtKUWeCndh28lYygtKDg6LN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=noJYTgMnxUpiXiNVyd7Z2dY+2uTUslxHMhFahJTk9IW0nI1DxxNOx/hbVxDmmo+iw XRfYSuJb3rG4lBshnI6NXrQsL4w/LXPYpPBAxDIo/izl+lSVeR3A5qQv+aaI6Slrmg b+k7KEWskvErl2xk6V+n6u8k9g1CH8dUJIsaSodQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Yongjun , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 548/639] rtlwifi: Fix file release memory leak Date: Fri, 24 Jan 2020 10:31:58 +0100 Message-Id: <20200124093157.799661387@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wei Yongjun [ Upstream commit 4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e ] When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") Signed-off-by: Wei Yongjun Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtlwifi/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c index d70385be99762..498994041bbcb 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -109,7 +109,7 @@ static const struct file_operations file_ops_common = { .open = dl_debug_open_common, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = single_release, }; static int rtl_debug_get_mac_page(struct seq_file *m, void *v) -- 2.20.1