From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DC9C2D0DB for ; Fri, 24 Jan 2020 11:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96C0D2077C for ; Fri, 24 Jan 2020 11:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865677; bh=1EsJ6qn9dEwaKmDyj1yN7qxoHEKJa6koM+zwdvlK2Y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y5iC5gBJoB79XK2g2FPjMMwNSnVh0b2fnzquxBAMHAECgmJCCALYtPT6wCnhyiDhz mFraTHRCgjiTe6dVCZU+vx/hC2J1waD8w/iG/niwMYHQT2Q3GvpxNEOesd7RuyXZ1U N+5kW+vDvojn2s6mVycUti9+44izb4X5viHLAkjk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404547AbgAXLdJ (ORCPT ); Fri, 24 Jan 2020 06:33:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:52502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404544AbgAXLdJ (ORCPT ); Fri, 24 Jan 2020 06:33:09 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3938320704; Fri, 24 Jan 2020 11:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865588; bh=1EsJ6qn9dEwaKmDyj1yN7qxoHEKJa6koM+zwdvlK2Y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R2kd5aLzT0VxhpwQplXXLBzUaq+lEhuqUGRHIOEjT8hwFJ4BH/qJJDe1AAz5XKx/h 83rp0HjKzjrHz8Dub9VBPQAsm4l6aXN8Jw2ss1W5Bo/Xv7YnBuUPXxsnkWb6Uvr82B OatblQC4/30YEWNN629f9j4GsiJxcKDh1ntmfiRY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jose Abreu , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 587/639] net: stmmac: gmac4+: Not all Unicast addresses may be available Date: Fri, 24 Jan 2020 10:32:37 +0100 Message-Id: <20200124093202.992850194@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jose Abreu [ Upstream commit 25683bab09a70542b9f8e3e28f79b3369e56701f ] Some setups may not have all Unicast addresses filters available. Check the number of available filters before trying to setup it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Jose Abreu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index 48cf5e2b24417..bc8871e7351f2 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -443,7 +443,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw, } /* Handle multiple unicast addresses */ - if (netdev_uc_count(dev) > GMAC_MAX_PERFECT_ADDRESSES) { + if (netdev_uc_count(dev) > hw->unicast_filter_entries) { /* Switch to promiscuous mode if more than 128 addrs * are required */ -- 2.20.1