From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F92C2D0DB for ; Fri, 24 Jan 2020 14:20:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 219FE22464 for ; Fri, 24 Jan 2020 14:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579875625; bh=B6Dk8xn/uBzWrLbdX1gWUgO9ftBCd/W5Llg4eiJ+9qI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=A3hS6/o2ERg8TSk5k2jybSc2TdOpb5whMA0PGrPMJ28uhYU/tHjkr0/F+wwQ/iByh QDicuhmk4HA6OuAfhKqX9Hv1X4Mwe63OOlbqEeGkqa3+MCBX0yMsdAKPRhzq5yfmFv FewQ8Fx42J0GfjfTsFatqsCvw+SMqxbNSdiyF4Lk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404818AbgAXOUX (ORCPT ); Fri, 24 Jan 2020 09:20:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:41374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404784AbgAXOUX (ORCPT ); Fri, 24 Jan 2020 09:20:23 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9687A22522; Fri, 24 Jan 2020 14:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579875622; bh=B6Dk8xn/uBzWrLbdX1gWUgO9ftBCd/W5Llg4eiJ+9qI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mbwQei3Q9qgzh+SuU0GY5xY56HyT3HsjrVHUJTEItb4lODaqx3vJjVJbUH90AJPHi XUUHDaoYqWtMognZrGc3NuYSvndcnwrG3oUUpkCThfMYJzJ07j/JScVjkdlJtbUrMv gGNjhaXLT1OncnhY+ZtyQNB7Wy0zweCWcyFEWag8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hewenliang , Steven Rostedt , Feilong Lin , Tzvetomir Stoyanov , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH AUTOSEL 4.19 08/56] tools lib traceevent: Fix memory leakage in filter_event Date: Fri, 24 Jan 2020 09:19:24 -0500 Message-Id: <20200124142012.29752-8-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200124142012.29752-1-sashal@kernel.org> References: <20200124142012.29752-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hewenliang [ Upstream commit f84ae29a6169318f9c929720c49d96323d2bbab9 ] It is necessary to call free_arg(arg) when add_filter_type() returns NULL in filter_event(). Signed-off-by: Hewenliang Reviewed-by: Steven Rostedt (VMware) Cc: Feilong Lin Cc: Tzvetomir Stoyanov Link: http://lore.kernel.org/lkml/20191209063549.59941-1-hewenliang4@huawei.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/lib/traceevent/parse-filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 2700f1f17876e..27248a0aad84a 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1227,8 +1227,10 @@ filter_event(struct event_filter *filter, struct event_format *event, } filter_type = add_filter_type(filter, event->id); - if (filter_type == NULL) + if (filter_type == NULL) { + free_arg(arg); return TEP_ERRNO__MEM_ALLOC_FAILED; + } if (filter_type->filter) free_arg(filter_type->filter); -- 2.20.1