stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
	Guillaume Tucker <guillaume.tucker@collabora.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	mgalka@collabora.com,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: stable-rc/linux-4.19.y bisection: baseline.login on sun8i-h3-libretech-all-h3-cc
Date: Fri, 24 Jan 2020 09:55:29 -0500	[thread overview]
Message-ID: <20200124145529.GG1706@sasha-vm> (raw)
In-Reply-To: <CACRpkdYdX-k+YT5wmyRzDnvaziwEDhYe82r3V2WOW6tyvNomFg@mail.gmail.com>

On Fri, Jan 24, 2020 at 02:44:19PM +0100, Linus Walleij wrote:
>On Fri, Jan 24, 2020 at 2:18 PM Mark Brown <broonie@kernel.org> wrote:
>> On Fri, Jan 24, 2020 at 12:58:32PM +0000, Guillaume Tucker wrote:
>>
>> > Please see the bisection report below about a boot failure, it
>> > looks legit as this commit was made today:
>>
>> > >     Fix it by ignoring the config in the device tree for now: the
>> > >     later patches in the series will push all inversion handling
>> > >     over to the gpiolib core and set it up properly in the
>> > >     boardfiles for legacy devices, but I did not finish that
>> > >     for this kernel cycle.
>
>So here the patch clearly says it is for "this kernel cycle"
>which I feel implies that it is NOT for any previous kernels
>stable or not...

This read to me as if this patch plasters the issue for now, and a
proper fix will follow in the next cycle.

>I'm sorry if I missed the "look at this thing that we will
>apply to stable soon" mail, sadly there are just too many
>of these for me to handle sometimes. (Maybe it means I
>am making too many mistakes to begin with, mea culpa.)
>
>> > >     Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
>> > >     Reported-by: Fabio Estevam <festevam@gmail.com>
>> > >     Reported-by: John Stultz <john.stultz@linaro.org>
>> > >     Reported-by: Anders Roxell <anders.roxell@linaro.org>
>> > >     Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> > >     Tested-by: John Stultz <john.stultz@linaro.org>
>> > >     Signed-off-by: Mark Brown <broonie@kernel.org>
>> > >     Signed-off-by: Sasha Levin <sashal@kernel.org>
>>
>> Oh dear, this is another bot backported commit which I suspect is
>> lacking some context or other from all the other work that was done with
>> GPIO enables :(
>
>This AI seems a bit confused :/
>Maybe it is the prolific use of the word "fix" that triggers it?

Right, it's a combo of a few things: one of them is indeed the work
"fix", but few others are the Reported-by tags, the simplicity of the
commit, and so on.

I'll drop this patch, sorry about this.

-- 
Thanks,
Sasha

      reply	other threads:[~2020-01-24 14:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5e2ad951.1c69fb81.6d762.dd8e@mx.google.com>
2020-01-24 12:58 ` stable-rc/linux-4.19.y bisection: baseline.login on sun8i-h3-libretech-all-h3-cc Guillaume Tucker
2020-01-24 13:18   ` Mark Brown
2020-01-24 13:44     ` Linus Walleij
2020-01-24 14:55       ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124145529.GG1706@sasha-vm \
    --to=sashal@kernel.org \
    --cc=broonie@kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guillaume.tucker@collabora.com \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalka@collabora.com \
    --cc=stable@vger.kernel.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).