From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Masato Suzuki <masato.suzuki@wdc.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sd: Fix REQ_OP_ZONE_REPORT completion handling
Date: Tue, 28 Jan 2020 09:04:57 +0100 [thread overview]
Message-ID: <20200128080457.GG2105706@kroah.com> (raw)
In-Reply-To: <yq1k15c9qkx.fsf@oracle.com>
On Mon, Jan 27, 2020 at 11:01:50PM -0500, Martin K. Petersen wrote:
>
> Damien,
>
> >> Fixes: 89d947561077 ("sd: Implement support for ZBC devices")
> >> Cc: <stable@vger.kernel.org> # 4.19
> >> Cc: <stable@vger.kernel.org> # 4.14
> >> Signed-off-by: Masato Suzuki <masato.suzuki@wdc.com>
> >
> > This bug exists since the beginning of SMR support in 4.10, until report
> > zones was changed to a device file method in kernel 4.20. It fell through
> > the cracks the entire time and was caught only recently with improvements
> > to our test suite.
>
> Looks good to me. Obviously only applies to stable since, as you point
> out, this code has been substantially reworked.
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Thanks for the review, now queued up.
greg k-h
prev parent reply other threads:[~2020-01-28 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 5:07 [PATCH] sd: Fix REQ_OP_ZONE_REPORT completion handling Masato Suzuki
2020-01-27 5:58 ` Damien Le Moal
2020-01-28 4:01 ` Martin K. Petersen
2020-01-28 8:04 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128080457.GG2105706@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Damien.LeMoal@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masato.suzuki@wdc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox