From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E70C33CB3 for ; Tue, 28 Jan 2020 14:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97BE420716 for ; Tue, 28 Jan 2020 14:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222922; bh=kzoeI0KGtDBmmy5T6mosoSPAI094vzMh7ao939kS9b8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AmsQGSewPcAjbi1N1zcZHOi40iuVp04w7q/DkSNeGHhAKOpfKtOb7bG/Lw885OvuE 9WsaCCpUBW7HwBt/5+6ERVxs8Nx3SI+Y04vJTeiwIomweSWcjIMljK2m0nqrX1YImd JkGiSY7GFvgxrQpgaq8A8/XcRjhA3ZQ17QrNHP6E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727593AbgA1OCP (ORCPT ); Tue, 28 Jan 2020 09:02:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:48522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727590AbgA1OCO (ORCPT ); Tue, 28 Jan 2020 09:02:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4A7724683; Tue, 28 Jan 2020 14:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220134; bh=kzoeI0KGtDBmmy5T6mosoSPAI094vzMh7ao939kS9b8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eMeEG6OfAWpEPq+wMLM3XMVsyrp5Cs/7tdGOi1Puj5dIZrK3hg/tUpFRmCOmCKWri JNqioo1ygZ1AnY4ThCI82SD3/mRHyL4eG/Hif/Pe+mlQwi+BtCPk+JnHLFxfxH+c3m Ekul8RqVFxC0iIJRyEHFpVqzw4LqtoAgV0yRDWvY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tariq Toukan , Boris Pismenny , Saeed Mahameed Subject: [PATCH 5.4 030/104] net/mlx5e: kTLS, Remove redundant posts in TX resync flow Date: Tue, 28 Jan 2020 14:59:51 +0100 Message-Id: <20200128135821.437418563@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135817.238524998@linuxfoundation.org> References: <20200128135817.238524998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tariq Toukan commit 1e92899791358dba94a9db7cc3b6004636b5a2f6 upstream. The call to tx_post_resync_params() is done earlier in the flow, the post of the control WQEs is unnecessarily repeated. Remove it. Fixes: 700ec4974240 ("net/mlx5e: kTLS, Fix missing SQ edge fill") Signed-off-by: Tariq Toukan Signed-off-by: Boris Pismenny Reviewed-by: Boris Pismenny Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c @@ -383,8 +383,6 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_kt if (unlikely(contig_wqebbs_room < num_wqebbs)) mlx5e_fill_sq_frag_edge(sq, wq, pi, contig_wqebbs_room); - tx_post_resync_params(sq, priv_tx, info.rcd_sn); - for (; i < info.nr_frags; i++) { unsigned int orig_fsz, frag_offset = 0, n = 0; skb_frag_t *f = &info.frags[i];