From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B65C2D0DB for ; Tue, 28 Jan 2020 14:35:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C366624686 for ; Tue, 28 Jan 2020 14:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222120; bh=HPDqMcXPKjRzu9+g2djNrlXaKW583imNTpPwyAM/U1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=egr4u25vFdquYk7BFq6pOa/olDIq7f0XUtxBOq/+wkdN814rTNiwYhgcCBsVqbDHb BisqY7SPvxR10F4prsvndxIGULCSpqJoywVIjHGOywoS+7RARsVZrDw40paEGN/QsM I9WXZdAFo/DiFH6fRKbehFLG7nYUnkc2ia/i0cTU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733077AbgA1OfT (ORCPT ); Tue, 28 Jan 2020 09:35:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:36344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731511AbgA1OfS (ORCPT ); Tue, 28 Jan 2020 09:35:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE9EF24685; Tue, 28 Jan 2020 14:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222118; bh=HPDqMcXPKjRzu9+g2djNrlXaKW583imNTpPwyAM/U1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LLtQrLiy4CjkpXxIEu5zNTZBpvqmR+eW+KUIxeFBcZRzJM1wLVn7nCfDyKtznSPsf siZQqrxK9gh5LCvOBOEdarHdiDcGXt2NoKUSzw6L9xvHOZiiBZYHATRgnrOfnLcr1L 6WIikavU/+3qv14Q3RZgbjpB+zpbvvKAMuiFJtYQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Lad, Prabhakar" , Akinobu Mita , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 079/183] media: ov2659: fix unbalanced mutex_lock/unlock Date: Tue, 28 Jan 2020 15:04:58 +0100 Message-Id: <20200128135837.813568256@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Akinobu Mita [ Upstream commit 384538bda10913e5c94ec5b5d34bd3075931bcf4 ] Avoid returning with mutex locked. Fixes: fa8cb6444c32 ("[media] ov2659: Don't depend on subdev API") Cc: "Lad, Prabhakar" Signed-off-by: Akinobu Mita Acked-by: Lad, Prabhakar Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov2659.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index 6eefb8bbb5b54..20e3c56991cf6 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -1137,7 +1137,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd, mf = v4l2_subdev_get_try_format(sd, cfg, fmt->pad); *mf = fmt->format; #else - return -ENOTTY; + ret = -ENOTTY; #endif } else { s64 val; -- 2.20.1