From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA8EC33CB3 for ; Tue, 28 Jan 2020 14:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DD5924691 for ; Tue, 28 Jan 2020 14:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222551; bh=MDVhzwSy+CT00CFyl7zN6IJUO7eVyLnaK9TRLK27Tzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yAKUOfg7eaSR1rZKaUzCR3c8D1YDe14Zx/hjxOqc8+P/+VB0f6dkxajay5bmf6Irf jYFe+obhPnyYjc8tfyybxebIDK3dsTkAlRy2qZexjblzNsRJkHeTLuu3dn4euJV3mM ZWLFUV1E60uq9OMVWQNLU7CAjydDcsTmHFvbWLHw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729603AbgA1OM7 (ORCPT ); Tue, 28 Jan 2020 09:12:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:34546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729330AbgA1OM7 (ORCPT ); Tue, 28 Jan 2020 09:12:59 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C4FA2468D; Tue, 28 Jan 2020 14:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220778; bh=MDVhzwSy+CT00CFyl7zN6IJUO7eVyLnaK9TRLK27Tzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nRkTPFf/dod5YYx2HwMOv8m9ffaEDhubCQvGJ4sdzyOia26wSvAuMaNWpZaDpSTtF BTP3DRW/EmapFNus5PITkioeDJ/nPilt+4EV1S/acTnWzjCR1BKAW9jrY6jdnR6zNe gPMcQ32a9LiMaa2+ual3gJLL5OuTHTszcHklWWN0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 142/183] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of_parse() Date: Tue, 28 Jan 2020 15:06:01 +0100 Message-Id: <20200128135843.948461441@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 231042181dc9d6122c6faba64e99ccb25f13cc6c ] The "gmac->phy_mode" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling will never be triggered. Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c index 82de68b1a4527..1fc356c177509 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c @@ -203,7 +203,7 @@ static void *ipq806x_gmac_of_parse(struct ipq806x_gmac *gmac) struct device *dev = &gmac->pdev->dev; gmac->phy_mode = of_get_phy_mode(dev->of_node); - if (gmac->phy_mode < 0) { + if ((int)gmac->phy_mode < 0) { dev_err(dev, "missing phy mode property\n"); return ERR_PTR(-EINVAL); } -- 2.20.1