From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81775C35249 for ; Sun, 2 Feb 2020 23:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D29C20679 for ; Sun, 2 Feb 2020 23:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580685593; bh=NcGwMPjbj2NTQU308Mo1hCCwmRBQTDcplWTju5yMm/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wJh+xxU0zSJJkcHIR3sCyoQ5Isc6ZNDhNlaHNGzSJ3TWtWiTWf7Sxx5+wtynt/gkB 2hJedxJ+KyF3ox96j/mRF7TrL1Xk7jbO24PaL6PDPqTiEJHyCr7xkRUv3xsJW0/oHo 2Vnk/d9gfEV7gxgLfbOAReWWTk8i5A09K0G4J+ks= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbgBBXTw (ORCPT ); Sun, 2 Feb 2020 18:19:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:52260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726443AbgBBXTw (ORCPT ); Sun, 2 Feb 2020 18:19:52 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A88D420643; Sun, 2 Feb 2020 23:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580685591; bh=NcGwMPjbj2NTQU308Mo1hCCwmRBQTDcplWTju5yMm/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JwpvRrhMr9vF/sQp/AUVPIEAdbLddoQcW90jlEo682VKi+o6AVkuI5/um3QefdLiA DxQn0Fbpe/dsu5dPpYDOa6y6cxC4nx2xFhAM9M5XcK7InQUjK4R6XBdjcRNVajotnc 4HD73Nrpn8/kY4LjdzVmDeiQ9XiQ7xrnhIThFd+8= Date: Sun, 2 Feb 2020 18:19:50 -0500 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: johan@kernel.org, amit.karwar@redpinesignals.com, fariyaf@gmail.com, kvalo@codeaurora.org, prameela.j04cs@gmail.com, siva.rebbagondla@redpinesignals.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] rsi: fix use-after-free on failed probe and unbind" failed to apply to 4.14-stable tree Message-ID: <20200202231950.GF1732@sasha-vm> References: <1580395053117151@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1580395053117151@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jan 30, 2020 at 03:37:33PM +0100, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 4.14-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From e93cd35101b61e4c79149be2cfc927c4b28dc60c Mon Sep 17 00:00:00 2001 >From: Johan Hovold >Date: Thu, 28 Nov 2019 18:22:00 +0100 >Subject: [PATCH] rsi: fix use-after-free on failed probe and unbind > >Make sure to stop both URBs before returning after failed probe as well >as on disconnect to avoid use-after-free in the completion handler. > >Reported-by: syzbot+b563b7f8dbe8223a51e8@syzkaller.appspotmail.com >Fixes: a4302bff28e2 ("rsi: add bluetooth rx endpoint") >Fixes: dad0d04fa7ba ("rsi: Add RS9113 wireless driver") >Cc: stable # 3.15 >Cc: Siva Rebbagondla >Cc: Prameela Rani Garnepudi >Cc: Amitkumar Karwar >Cc: Fariya Fatima >Signed-off-by: Johan Hovold >Signed-off-by: Kalle Valo Conflicts around support for suspend/resume. I've also queued up cbde979b33fa ("rsi: add hci detach for hibernation and poweroff") for 4.19 and 4.14. -- Thanks, Sasha