From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E719FC35247 for ; Mon, 3 Feb 2020 16:23:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B525E2080D for ; Mon, 3 Feb 2020 16:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580746991; bh=sHEQDUxJfVWLAxmiD8XRiG1UUW3yDrMrHX0kipaQi00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Z6IOAl7ZacliYnr1qub7d9k3i/2/1JXA7R4UtABVuJyCSfBaLkHfuUWIaWkgmyumF D1A00bNu1zF7IcgUXTbLm4J2p7WulxrL6Qh36y3sjBOX5IasNNEEm0+60n1jGDfFOZ 2nO2jlqT1mq1BNLpVdFDoYIHjVvvJIvLlxm1IlPk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728827AbgBCQUT (ORCPT ); Mon, 3 Feb 2020 11:20:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:60062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbgBCQUT (ORCPT ); Mon, 3 Feb 2020 11:20:19 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9690620838; Mon, 3 Feb 2020 16:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580746819; bh=sHEQDUxJfVWLAxmiD8XRiG1UUW3yDrMrHX0kipaQi00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gQv2GXP/TGTf8YVVJmPAd1FGYPdvjbC/SYrgAu2tD0nn26B/Dny4MSCyrvT1yonaM 3twDSEaVmsiN4TQBH33qd1U+uAvjLDRMxWrR/pgdlz+po5/eC8WefCcBKJJB43IV4V 1fhsHQpaRm4R3LECV3WTdX0dun/BzKCa7jcG2ePM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Kalle Valo Subject: [PATCH 4.4 02/53] orinoco_usb: fix interface sanity check Date: Mon, 3 Feb 2020 16:18:54 +0000 Message-Id: <20200203161903.457277571@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161902.714326084@linuxfoundation.org> References: <20200203161902.714326084@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Johan Hovold commit b73e05aa543cf8db4f4927e36952360d71291d41 upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 9afac70a7305 ("orinoco: add orinoco_usb driver") Cc: stable # 2.6.35 Signed-off-by: Johan Hovold Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/orinoco/orinoco_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/wireless/orinoco/orinoco_usb.c +++ b/drivers/net/wireless/orinoco/orinoco_usb.c @@ -1601,9 +1601,9 @@ static int ezusb_probe(struct usb_interf /* set up the endpoint information */ /* check out the endpoints */ - iface_desc = &interface->altsetting[0].desc; + iface_desc = &interface->cur_altsetting->desc; for (i = 0; i < iface_desc->bNumEndpoints; ++i) { - ep = &interface->altsetting[0].endpoint[i].desc; + ep = &interface->cur_altsetting->endpoint[i].desc; if (usb_endpoint_is_bulk_in(ep)) { /* we found a bulk in endpoint */