From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A35C35247 for ; Mon, 3 Feb 2020 16:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 549C820CC7 for ; Mon, 3 Feb 2020 16:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747302; bh=exqW1YB8XKZ3dbWmNRrCkY4Cyio9kpbWiIWBCqpb6Tk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2qmXbB0B9DS7WR9aKoWXr/72slO63w28ZGwZKNPR6Ga89bM5dCinu4PlJ/SQR0L/Q 1dyej+twJ/OCAaZA/FWw8qRxmpe1Hq32LGEnmjwZizrTwxDuYjSSoUn9SBFbMNatzM 9u5z7z/55mOVJLBQiXgkV/3SqHI6PJ8boxujk4t4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729565AbgBCQ2U (ORCPT ); Mon, 3 Feb 2020 11:28:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:39836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729559AbgBCQ2T (ORCPT ); Mon, 3 Feb 2020 11:28:19 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F50120CC7; Mon, 3 Feb 2020 16:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747299; bh=exqW1YB8XKZ3dbWmNRrCkY4Cyio9kpbWiIWBCqpb6Tk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SAiat6x9ti6FyQwDwiBDa0PXN8cLVkDSKZld0bw2oPaEEmnrRavX52nsfP0HShAdA oC/P99z9djLs0qj6IAiYlA3cWwRZfVzIhtA658ndTzzAFoH6ST8AY/B9ILEcYy2olf S9eIf4PFIZhZ7g1ZbsId9+MhictwbWeYz623Pt+c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King Subject: [PATCH 4.14 08/89] staging: wlan-ng: ensure error return is actually returned Date: Mon, 3 Feb 2020 16:18:53 +0000 Message-Id: <20200203161917.937635999@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161916.847439465@linuxfoundation.org> References: <20200203161916.847439465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Colin Ian King commit 4cc41cbce536876678b35e03c4a8a7bb72c78fa9 upstream. Currently when the call to prism2sta_ifst fails a netdev_err error is reported, error return variable result is set to -1 but the function always returns 0 for success. Fix this by returning the error value in variable result rather than 0. Addresses-Coverity: ("Unused value") Fixes: 00b3ed168508 ("Staging: add wlan-ng prism2 usb driver") Signed-off-by: Colin Ian King Cc: stable Link: https://lore.kernel.org/r/20200114181604.390235-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -945,7 +945,7 @@ int prism2mgmt_flashdl_state(struct wlan } } - return 0; + return result; } /*----------------------------------------------------------------