From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614B1C2D0B1 for ; Tue, 4 Feb 2020 10:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28CC9217BA for ; Tue, 4 Feb 2020 10:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580810422; bh=i4/pV3yXt1Xq5NaSU6N3KYYw34q7CC7h07LBX1XrFKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Y1dcT7f0jtiDo3jBQsNeG47Y1F5v5OpXw/y4hSBM0SnCPvQLWFz2jCmM27gMrhB8k 8i6ViQbHcBi5ihpU7Z9zPiCj8mQ6EKe4Kr747/KeyjX7LeM/Zrjc8gtsQRu5/u0fy1 Xm/MlYbJUU7M0C1uua9gj2JhygBOxHydDeCFydIQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbgBDKAV (ORCPT ); Tue, 4 Feb 2020 05:00:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:38910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbgBDKAV (ORCPT ); Tue, 4 Feb 2020 05:00:21 -0500 Received: from localhost (unknown [212.187.182.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 398F3217BA; Tue, 4 Feb 2020 10:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580810420; bh=i4/pV3yXt1Xq5NaSU6N3KYYw34q7CC7h07LBX1XrFKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WcZprKCXPGJibCXsrLvxeuo1CW7VAvOY7oSXtV1zu8WkgBtiFdtvj6hdD97dmZyH4 c/SHnqYnyNp9da4tCocaDR/ZG+4kOJWSm+pH/u5z+8YA3yXKHgWbfgC3lx5cTmHK02 n+HpahEMU8dyzKY5EbnkoaewR/3Al7PnMd0MnJqM= Date: Tue, 4 Feb 2020 10:00:16 +0000 From: Greg Kroah-Hartman To: Johan Hovold Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Amitkumar Karwar , Siva Rebbagondla , Kalle Valo , Denis Efremov Subject: Re: [PATCH 5.4 117/203] rsi: fix potential null dereference in rsi_probe() Message-ID: <20200204100016.GA1088789@kroah.com> References: <20200116231745.218684830@linuxfoundation.org> <20200116231755.604943633@linuxfoundation.org> <20200204083332.GE26725@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200204083332.GE26725@localhost> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Feb 04, 2020 at 09:33:32AM +0100, Johan Hovold wrote: > On Fri, Jan 17, 2020 at 12:17:14AM +0100, Greg Kroah-Hartman wrote: > > From: Denis Efremov > > > > commit f170d44bc4ec2feae5f6206980e7ae7fbf0432a0 upstream. > > > > The id pointer can be NULL in rsi_probe(). It is checked everywhere except > > for the else branch in the idProduct condition. The patch adds NULL check > > before the id dereference in the rsi_dbg() call. > > > > Fixes: 54fdb318c111 ("rsi: add new device model for 9116") > > Cc: Amitkumar Karwar > > Cc: Siva Rebbagondla > > Cc: Kalle Valo > > Signed-off-by: Denis Efremov > > Signed-off-by: Kalle Valo > > Signed-off-by: Greg Kroah-Hartman > > This commit is bogus and was reverted shortly after it was applied in > order to prevent autosel from picking it up for stable (reverted by > c5dcf8f0e850 ("Revert "rsi: fix potential null dereference in > rsi_probe()"")). > > The revert has now been picked up by Sasha, but shouldn't an > explicit revert in the same pull-request prevent a bad patch from being > backported in the first place? Seems like something that could be > scripted. But perhaps the net-stable oddities come into play here. This was my fault, I picked it up, and didn't run a "has this patch been reverted" type search on them. I'll add that to my workflow, sorry. greg k-h