From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029CCC352A3 for ; Thu, 6 Feb 2020 19:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1B3C218AC for ; Thu, 6 Feb 2020 19:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581016519; bh=sUVpIaSQQv1sYxD093i3Qi8GgU7i0xULu1GEuvClAiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B52FbSoxZjF+KgvOJm73I3HMUuQ1w5ybgvkZweTIBb6M3btYVZM+kwU1KZpLDQyv0 JBB/v2+Xq6i5tgzbGsdfxjKXH5NsxO+mCP4v7BJQCY5vLunjh1PQN+zXurzQgecJIa qkoOiC2iIi12Mf8eSF0O8jNQDDly/Y0HdH8lJdXk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbgBFTPT (ORCPT ); Thu, 6 Feb 2020 14:15:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:55718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726990AbgBFTPS (ORCPT ); Thu, 6 Feb 2020 14:15:18 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F414221741; Thu, 6 Feb 2020 19:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581016518; bh=sUVpIaSQQv1sYxD093i3Qi8GgU7i0xULu1GEuvClAiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yg+6gqpsUU1cUIhlvlTxyt5y/hQXnm8u2tx0Fot+b4gLse7f8mhHb2sq6g3D7/Tfp ZOQ8Bcnk5AZw2/yoPHsVT1VjVGxMQJ5HmoPmESTG7ommtclhP1L80hcMY0HG08iHj0 TU3aLUTLpiHll4+khNScifRGyPW1i8kVreUFTi2w= Date: Thu, 6 Feb 2020 14:15:17 -0500 From: Sasha Levin To: Florian Bezdeka Cc: stable@vger.kernel.org, Eric Biggers , Herbert Xu Subject: Re: [PATCH 4.19] crypto: geode-aes - convert to skcipher API and make thread-safe Message-ID: <20200206191517.GO31482@sasha-vm> References: <20200206171534.4051-1-florian@bezdeka.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200206171534.4051-1-florian@bezdeka.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 06, 2020 at 06:15:34PM +0100, Florian Bezdeka wrote: >commit 4549f7e5aa27ffc2cba63b5db8842a3b486f5688 upstream. > >The geode AES driver is heavily broken because it stores per-request >state in the transform context. So it will crash or produce the wrong >result if used by any of the many places in the kernel that issue >concurrent requests for the same transform object. > >This driver is also implemented using the deprecated blkcipher API, >which makes it difficult to fix, and puts it among the drivers >preventing that API from being removed. > >Convert this driver to use the skcipher API, and change it to not store >per-request state in the transform context. > >Fixes: 9fe757b ("[PATCH] crypto: Add support for the Geode LX AES hardware") >Signed-off-by: Eric Biggers >Signed-off-by: Herbert Xu >Signed-off-by: Florian Bezdeka Queued up, thanks! -- Thanks, Sasha