From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: trondmy@gmail.com, Anna.Schumaker@Netapp.com,
bcodding@redhat.com, trond.myklebust@hammerspace.com,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] NFS: Fix memory leaks and corruption in readdir" failed to apply to 4.9-stable tree
Date: Sun, 9 Feb 2020 10:11:51 -0500 [thread overview]
Message-ID: <20200209151151.GA3584@sasha-vm> (raw)
In-Reply-To: <158124745033180@kroah.com>
On Sun, Feb 09, 2020 at 12:24:10PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.9-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 4b310319c6a8ce708f1033d57145e2aa027a883c Mon Sep 17 00:00:00 2001
>From: Trond Myklebust <trondmy@gmail.com>
>Date: Sun, 2 Feb 2020 17:53:53 -0500
>Subject: [PATCH] NFS: Fix memory leaks and corruption in readdir
>
>nfs_readdir_xdr_to_array() must not exit without having initialised
>the array, so that the page cache deletion routines can safely
>call nfs_readdir_clear_array().
>Furthermore, we should ensure that if we exit nfs_readdir_filler()
>with an error, we free up any page contents to prevent a leak
>if we try to fill the page again.
>
>Fixes: 11de3b11e08c ("NFS: Fix a memory leak in nfs_readdir")
>Cc: stable@vger.kernel.org # v2.6.37+
>Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
>Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
>Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
I also took b044f6451384 ("NFS: switch back to to ->iterate()") and
queued both for 4.9 and 4.4.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-02-09 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 11:24 FAILED: patch "[PATCH] NFS: Fix memory leaks and corruption in readdir" failed to apply to 4.9-stable tree gregkh
2020-02-09 15:11 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200209151151.GA3584@sasha-vm \
--to=sashal@kernel.org \
--cc=Anna.Schumaker@Netapp.com \
--cc=bcodding@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox