Re: FAILED: patch "[PATCH] btrfs: free block groups after free'ing fs trees" failed to apply to 5.4-stable tree

[Sasha Levin <sashal@kernel.org>]

On Sun, Feb 09, 2020 at 12:30:41PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.4-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 4e19443da1941050b346f8fc4c368aa68413bc88 Mon Sep 17 00:00:00 2001
>From: Josef Bacik <josef@toxicpanda.com>
>Date: Tue, 21 Jan 2020 09:17:06 -0500
>Subject: [PATCH] btrfs: free block groups after free'ing fs trees
>
>Sometimes when running generic/475 we would trip the
>WARN_ON(cache->reserved) check when free'ing the block groups on umount.
>This is because sometimes we don't commit the transaction because of IO
>errors and thus do not cleanup the tree logs until at umount time.
>
>These blocks are still reserved until they are cleaned up, but they
>aren't cleaned up until _after_ we do the free block groups work.  Fix
>this by moving the free after free'ing the fs roots, that way all of the
>tree logs are cleaned up and we have a properly cleaned fs.  A bunch of
>loops of generic/475 confirmed this fixes the problem.
>
>CC: stable@vger.kernel.org # 4.9+
>Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>Reviewed-by: David Sterba <dsterba@suse.com>
>Signed-off-by: David Sterba <dsterba@suse.com>

I took 4273eaff9b8d ("btrfs: use bool argument in free_root_pointers()")
too and queued both for 5.4-4.9.

-- 
Thanks,
Sasha