Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: sean.j.christopherson@intel.com, pbonzini@redhat.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] KVM: Play nice with read-only memslots when querying host" failed to apply to 5.5-stable tree
Date: Sun, 9 Feb 2020 16:29:28 -0500	[thread overview]
Message-ID: <20200209212928.GE3584@sasha-vm> (raw)
In-Reply-To: <158125181221109@kroah.com>

On Sun, Feb 09, 2020 at 01:36:52PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.5-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 42cde48b2d39772dba47e680781a32a6c4b7dc33 Mon Sep 17 00:00:00 2001
>From: Sean Christopherson <sean.j.christopherson@intel.com>
>Date: Wed, 8 Jan 2020 12:24:38 -0800
>Subject: [PATCH] KVM: Play nice with read-only memslots when querying host
> page size
>
>Avoid the "writable" check in __gfn_to_hva_many(), which will always fail
>on read-only memslots due to gfn_to_hva() assuming writes.  Functionally,
>this allows x86 to create large mappings for read-only memslots that
>are backed by HugeTLB mappings.
>
>Note, the changelog for commit 05da45583de9 ("KVM: MMU: large page
>support") states "If the largepage contains write-protected pages, a
>large pte is not used.", but "write-protected" refers to pages that are
>temporarily read-only, e.g. read-only memslots didn't even exist at the
>time.
>
>Fixes: 4d8b81abc47b ("KVM: introduce readonly memslot")
>Cc: stable@vger.kernel.org
>Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>[Redone using kvm_vcpu_gfn_to_memslot_prot. - Paolo]
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I'm not sure what was wrong with 5.5-4.14, it applied/built fine for me.

For 4.9 and 4.4, it depends on f9b84e19221e ("KVM: Use vcpu-specific
gva->hva translation when querying host page size") which wasn't
backported that far, so this one should also be backported to 4.9 and
4.4.

-- 
Thanks,
Sasha

      reply	other threads:[~2020-02-09 21:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 12:36 FAILED: patch "[PATCH] KVM: Play nice with read-only memslots when querying host" failed to apply to 5.5-stable tree gregkh
2020-02-09 21:29 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200209212928.GE3584@sasha-vm \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox