From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C84C3B18B for ; Thu, 13 Feb 2020 15:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9385020661 for ; Thu, 13 Feb 2020 15:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581608576; bh=qalAB5bKEGVK827bqT35jJirfnT6wm6bOd0KLJ3sqa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OV4OovhB3oK67WzC8cDvsrUsxYtGLrg9cQQdYWtFX8xJBriR5LZZ58IH9Vnkr+vU5 Oue0dcacD8eQfTfduabbhnCf0X/qmVgkrCBVY8RYplvobJ6gLisQZ9wdiEUUcVF+8K xUojoGErcfRSYtocF6MTjJoPqiaolsu9fThb+AcQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729057AbgBMP2F (ORCPT ); Thu, 13 Feb 2020 10:28:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:54040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729539AbgBMP2D (ORCPT ); Thu, 13 Feb 2020 10:28:03 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C749F206DB; Thu, 13 Feb 2020 15:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607682; bh=qalAB5bKEGVK827bqT35jJirfnT6wm6bOd0KLJ3sqa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yC3KPv7mK7YRLq+rZn++f6aVivYYO1j3GpIWY1r68PxEs5k7Ej3+pBP6WyNVoWOMZ Q6Lbs8H/1emNpnPo7wiHCl7HIUiXerUs2UNeCGtd860c+NQKJn//mycU1qS7ne6D/C ajnva7UwXUWevdiVX3N6HqLveVhiT1zs1aS0iHLU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiyu Yang , Xin Tan , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 5.5 006/120] RDMA/i40iw: fix a potential NULL pointer dereference Date: Thu, 13 Feb 2020 07:20:02 -0800 Message-Id: <20200213151903.615842568@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151901.039700531@linuxfoundation.org> References: <20200213151901.039700531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Xiyu Yang commit 04db1580b5e48a79e24aa51ecae0cd4b2296ec23 upstream. A NULL pointer can be returned by in_dev_get(). Thus add a corresponding check so that a NULL pointer dereference will be avoided at this place. Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status") Link: https://lore.kernel.org/r/1577672668-46499-1-git-send-email-xiyuyang19@fudan.edu.cn Signed-off-by: Xiyu Yang Signed-off-by: Xin Tan Reviewed-by: Leon Romanovsky Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/i40iw/i40iw_main.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/infiniband/hw/i40iw/i40iw_main.c +++ b/drivers/infiniband/hw/i40iw/i40iw_main.c @@ -1225,6 +1225,8 @@ static void i40iw_add_ipv4_addr(struct i const struct in_ifaddr *ifa; idev = in_dev_get(dev); + if (!idev) + continue; in_dev_for_each_ifa_rtnl(ifa, idev) { i40iw_debug(&iwdev->sc_dev, I40IW_DEBUG_CM, "IP=%pI4, vlan_id=%d, MAC=%pM\n", &ifa->ifa_address,