stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Schrempf Frieder <frieder.schrempf@kontron.de>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 0/2] serial: imx: Backport fixes for irq handling to v4.14
Date: Tue, 18 Feb 2020 08:17:44 +0100	[thread overview]
Message-ID: <20200218071744.GA2087281@kroah.com> (raw)
In-Reply-To: <20200218070310.ibv2m2f7ihfaevrp@pengutronix.de>

On Tue, Feb 18, 2020 at 08:03:10AM +0100, Uwe Kleine-König wrote:
> On Tue, Feb 18, 2020 at 05:50:08AM +0100, gregkh@linuxfoundation.org wrote:
> > On Mon, Feb 17, 2020 at 02:08:00PM +0000, Schrempf Frieder wrote:
> > > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> > > 
> > > A customer of ours has problems with RS485 on i.MX6UL with the latest v4.14
> > > kernel. They get an exception like below from time to time (the trace is
> > > from an older kernel, but the problem also exists in v4.14.170).
> > > 
> > > As the cpuidle state 2 causes large delays for the interrupt that controls the
> > > RS485 RTS signal (which can lead to collisions on the bus), cpuidle state 2 was
> > > disabled on this system. This aspect might cause the exception happening more
> > > often on this system than on other systems with default cpuidle settings.
> > > 
> > > Looking for solutions I found Uwe's patches that were applied in v4.17 being
> > > mentioned here [1] and here [2]. In [1] Uwe notes that backporting these fixes
> > > to v4.14 might not be trivial, but I tried and in my opinion found it not to be
> > > too problematic either.
> > > 
> > > With the backported patches applied, our customer reports that the exceptions
> > > stopped occuring. Given this and the fact that the problem seems to be known
> > > and quite common, it would be nice to get this into the v4.14 stable tree. 
> > 
> > Thanks for the backports, both now queued up.
> 
> To complete these fixes you also want to backport
> 
> 	101aa46bd221 serial: imx: fix a race condition in receive path

If so, it needs to also go to 4.19.y, and someone needs to provide a
working backport for both places :)

thanks,

greg k-h

  reply	other threads:[~2020-02-18  7:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 14:08 [PATCH 0/2] serial: imx: Backport fixes for irq handling to v4.14 Schrempf Frieder
2020-02-17 14:08 ` [PATCH 1/2] serial: imx: ensure that RX irqs are off if RX is off Schrempf Frieder
2020-02-17 14:08 ` [PATCH 2/2] serial: imx: Only handle irqs that are actually enabled Schrempf Frieder
2020-02-18  4:50 ` [PATCH 0/2] serial: imx: Backport fixes for irq handling to v4.14 gregkh
2020-02-18  7:03   ` Uwe Kleine-König
2020-02-18  7:17     ` gregkh [this message]
2020-02-18  9:44       ` Schrempf Frieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218071744.GA2087281@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).