From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: jack@suse.cz, scan-admin@coverity.com, tytso@mit.edu,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] ext4: simplify checking quota limits in ext4_statfs()" failed to apply to 5.5-stable tree
Date: Tue, 18 Feb 2020 11:34:34 -0500 [thread overview]
Message-ID: <20200218163434.GO1734@sasha-vm> (raw)
In-Reply-To: <1581966460247127@kroah.com>
On Mon, Feb 17, 2020 at 08:07:40PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.5-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 46d36880d1c6f9b9a0cbaf90235355ea1f4cab96 Mon Sep 17 00:00:00 2001
>From: Jan Kara <jack@suse.cz>
>Date: Thu, 30 Jan 2020 12:11:48 +0100
>Subject: [PATCH] ext4: simplify checking quota limits in ext4_statfs()
>
>Coverity reports that conditions checking quota limits in ext4_statfs()
>contain dead code. Indeed it is right and current conditions can be
>simplified.
>
>Link: https://lore.kernel.org/r/20200130111148.10766-1-jack@suse.cz
>Reported-by: Coverity <scan-admin@coverity.com>
>Signed-off-by: Jan Kara <jack@suse.cz>
>Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>Cc: stable@kernel.org
I've also grabbed 57c32ea42f8e ("ext4: choose hardlimit when softlimit
is larger than hardlimit in ext4_statfs_project()") which fixes a user
visible issue and introduces the issue fixed by this patch.
Both queued for 5.5 and 5.4.
I'm not quite sure that this patch is stable material.
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-02-18 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 19:07 FAILED: patch "[PATCH] ext4: simplify checking quota limits in ext4_statfs()" failed to apply to 5.5-stable tree gregkh
2020-02-18 16:34 ` Sasha Levin [this message]
2020-02-18 17:08 ` Theodore Y. Ts'o
2020-02-18 18:21 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218163434.GO1734@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=scan-admin@coverity.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).