stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Sasha Levin <sashal@kernel.org>
Cc: gregkh@linuxfoundation.org, pbonzini@redhat.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] KVM: x86/mmu: Fix struct guest_walker arrays for 5-level" failed to apply to 5.4-stable tree
Date: Tue, 18 Feb 2020 09:47:25 -0800	[thread overview]
Message-ID: <20200218174725.GB28156@linux.intel.com> (raw)
In-Reply-To: <20200218174451.GT1734@sasha-vm>

On Tue, Feb 18, 2020 at 12:44:51PM -0500, Sasha Levin wrote:
> On Mon, Feb 17, 2020 at 08:14:31PM +0100, gregkh@linuxfoundation.org wrote:
> >
> >The patch below does not apply to the 5.4-stable tree.
> >If someone wants it applied there, or to any other stable or longterm
> >tree, then please email the backport, including the original git commit
> >id to <stable@vger.kernel.org>.
> >
> >thanks,
> >
> >greg k-h
> >
> >------------------ original commit in Linus's tree ------------------
> >
> >From f6ab0107a4942dbf9a5cf0cca3f37e184870a360 Mon Sep 17 00:00:00 2001
> >From: Sean Christopherson <sean.j.christopherson@intel.com>
> >Date: Fri, 7 Feb 2020 09:37:42 -0800
> >Subject: [PATCH] KVM: x86/mmu: Fix struct guest_walker arrays for 5-level
> >paging
> >
> >Define PT_MAX_FULL_LEVELS as PT64_ROOT_MAX_LEVEL, i.e. 5, to fix shadow
> >paging for 5-level guest page tables.  PT_MAX_FULL_LEVELS is used to
> >size the arrays that track guest pages table information, i.e. using a
> >"max levels" of 4 causes KVM to access garbage beyond the end of an
> >array when querying state for level 5 entries.  E.g. FNAME(gpte_changed)
> >will read garbage and most likely return %true for a level 5 entry,
> >soft-hanging the guest because FNAME(fetch) will restart the guest
> >instead of creating SPTEs because it thinks the guest PTE has changed.
> >
> >Note, KVM doesn't yet support 5-level nested EPT, so PT_MAX_FULL_LEVELS
> >gets to stay "4" for the PTTYPE_EPT case.
> >
> >Fixes: 855feb673640 ("KVM: MMU: Add 5 level EPT & Shadow page table support.")
> >Cc: stable@vger.kernel.org
> >Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> >Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> File name is different in 5.4 and 4.19. Fixed and queued up for both.

Thanks!  Backporting the non-trivial conflicts is on my todo list,
unfortunately my todo list is rather long right now...

      reply	other threads:[~2020-02-18 17:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 19:14 FAILED: patch "[PATCH] KVM: x86/mmu: Fix struct guest_walker arrays for 5-level" failed to apply to 5.4-stable tree gregkh
2020-02-18 17:44 ` Sasha Levin
2020-02-18 17:47   ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218174725.GB28156@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=pbonzini@redhat.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).