From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD092C34047 for ; Tue, 18 Feb 2020 20:05:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C40B21D56 for ; Tue, 18 Feb 2020 20:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582056314; bh=j0PgUILrAPLlqw9FlakRmgTtyD9KYhlMmIoEr2+Azow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ieuNd5koOTba18xVUv1T6tUxvRMxL/u4v4j7s0CEvSWZTguXfKxJkK/+BNw2MmMvW 4Y2rymexMJ037yJo65dziCrpUWNv2hWmZBjll3K4P+QClaTewQQmu9d8v4o4ZlFXdt fuXcJtM6A/fyPBj/gmbU8X+XBbnDfFvnR0USiWtk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728874AbgBRUCM (ORCPT ); Tue, 18 Feb 2020 15:02:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:42350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728706AbgBRUCL (ORCPT ); Tue, 18 Feb 2020 15:02:11 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 821E324670; Tue, 18 Feb 2020 20:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582056131; bh=j0PgUILrAPLlqw9FlakRmgTtyD9KYhlMmIoEr2+Azow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pPtCiOxh5WLQ5Klqe3DXH8vXpMtUKYDj3h98XN6oxVWUTacqJ1tvMVV8STY6YMAk9 c7+q7ALBgjfa7Ax02s3uMJDCVLrvG4w9O7p/JAfEQ7/A2ml93Cf97l4sjHCsCaT04q 17OnmvG193qAqXkIZqHskE9ofYzErsqrZT1yj7RU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Asmaa Mnebhi , Corey Minyard Subject: [PATCH 5.5 47/80] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write Date: Tue, 18 Feb 2020 20:55:08 +0100 Message-Id: <20200218190436.795711768@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200218190432.043414522@linuxfoundation.org> References: <20200218190432.043414522@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Colin Ian King commit e0354d147e5889b5faa12e64fa38187aed39aad4 upstream. The end of buffer check is off-by-one since the check is against an index that is pre-incremented before a store to buf[]. Fix this adjusting the bounds check appropriately. Addresses-Coverity: ("Out-of-bounds write") Fixes: 51bd6f291583 ("Add support for IPMB driver") Signed-off-by: Colin Ian King Message-Id: <20200114144031.358003-1-colin.king@canonical.com> Reviewed-by: Asmaa Mnebhi Signed-off-by: Corey Minyard Signed-off-by: Greg Kroah-Hartman --- drivers/char/ipmi/ipmb_dev_int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi/ipmb_dev_int.c @@ -253,7 +253,7 @@ static int ipmb_slave_cb(struct i2c_clie break; case I2C_SLAVE_WRITE_RECEIVED: - if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg)) + if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg) - 1) break; buf[++ipmb_dev->msg_idx] = *val;