stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Sasha Levin <sashal@kernel.org>,
	sean.j.christopherson@intel.com, pbonzini@redhat.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] KVM: VMX: Add non-canonical check on writes to RTIT address" failed to apply to 4.19-stable tree
Date: Thu, 20 Feb 2020 11:01:38 +0100	[thread overview]
Message-ID: <20200220100138.GB3340412@kroah.com> (raw)
In-Reply-To: <fc00f38ef8db90d982dad4de41e97918b565d321.camel@codethink.co.uk>

On Thu, Feb 20, 2020 at 09:16:51AM +0000, Ben Hutchings wrote:
> On Sun, 2020-02-09 at 15:12 -0500, Sasha Levin wrote:
> > On Sun, Feb 09, 2020 at 01:31:58PM +0100, gregkh@linuxfoundation.org wrote:
> > > The patch below does not apply to the 4.19-stable tree.
> > > If someone wants it applied there, or to any other stable or longterm
> > > tree, then please email the backport, including the original git commit
> > > id to <stable@vger.kernel.org>.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > > ------------------ original commit in Linus's tree ------------------
> > > 
> > > From fe6ed369fca98e99df55c932b85782a5687526b5 Mon Sep 17 00:00:00 2001
> > > From: Sean Christopherson <sean.j.christopherson@intel.com>
> > > Date: Tue, 10 Dec 2019 15:24:32 -0800
> > > Subject: [PATCH] KVM: VMX: Add non-canonical check on writes to RTIT address
> > > MSRs
> > > 
> > > Reject writes to RTIT address MSRs if the data being written is a
> > > non-canonical address as the MSRs are subject to canonical checks, e.g.
> > > KVM will trigger an unchecked #GP when loading the values to hardware
> > > during pt_guest_enter().
> > > 
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > 
> > File/code movement. Cleaned up and queued for 4.19-4.4.
> 
> I don't know what happened here, but you've ended up adding the
> entirety of arch/x86/kvm/vmx/vmx.c on all those branches rather than
> applying the change to the right file.

Oh wow that's wrong :(

I'll go revert this, as it's not actually doing anything.

Thanks for catching this.

greg k-h

  reply	other threads:[~2020-02-20 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 12:31 FAILED: patch "[PATCH] KVM: VMX: Add non-canonical check on writes to RTIT address" failed to apply to 4.19-stable tree gregkh
2020-02-09 20:12 ` Sasha Levin
2020-02-20  9:16   ` Ben Hutchings
2020-02-20 10:01     ` Greg KH [this message]
2020-02-20 12:14     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220100138.GB3340412@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=sashal@kernel.org \
    --cc=sean.j.christopherson@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).