From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB9BC11D04 for ; Thu, 20 Feb 2020 10:01:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B53AD24672 for ; Thu, 20 Feb 2020 10:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582192902; bh=n7K3Dqw6vjjfVIdr6F49vaBk4P+O2b3FLRtRpPxlXj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=k7idTfaTciHXdZuzK2fW57MKTV5MKKh61hqyhUrmTphZXTqeHCC0dPOhApXy20w+l yursXQqrikBsytyjzabVizdi7eICcpjCd4T0X6UCyp/OycruMTEev2VOmKvJN/btsN ZxueqIXR4qh3jKboAqC2PSHVaYhkfNZEVdeD/iMs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727227AbgBTKBm (ORCPT ); Thu, 20 Feb 2020 05:01:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:33604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbgBTKBm (ORCPT ); Thu, 20 Feb 2020 05:01:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D96F24654; Thu, 20 Feb 2020 10:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582192900; bh=n7K3Dqw6vjjfVIdr6F49vaBk4P+O2b3FLRtRpPxlXj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VInbJUFFjpWmCwZtfHLJ1WHCveiEnf439ikbY51+bZCgWl1ph/EiqMRHcBiwPylj2 r5RmOOYpLwFAr1MKKMhndPn8g0BqZTNviJGgtr3D0/q/m3ib9JNz0DY3/uVclHuNBa JPplSn8MkStfS6cHzXWhfzYZO/LwOt2zNBOnpCkM= Date: Thu, 20 Feb 2020 11:01:38 +0100 From: Greg KH To: Ben Hutchings Cc: Sasha Levin , sean.j.christopherson@intel.com, pbonzini@redhat.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] KVM: VMX: Add non-canonical check on writes to RTIT address" failed to apply to 4.19-stable tree Message-ID: <20200220100138.GB3340412@kroah.com> References: <15812515183712@kroah.com> <20200209201223.GZ3584@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 20, 2020 at 09:16:51AM +0000, Ben Hutchings wrote: > On Sun, 2020-02-09 at 15:12 -0500, Sasha Levin wrote: > > On Sun, Feb 09, 2020 at 01:31:58PM +0100, gregkh@linuxfoundation.org wrote: > > > The patch below does not apply to the 4.19-stable tree. > > > If someone wants it applied there, or to any other stable or longterm > > > tree, then please email the backport, including the original git commit > > > id to . > > > > > > thanks, > > > > > > greg k-h > > > > > > ------------------ original commit in Linus's tree ------------------ > > > > > > From fe6ed369fca98e99df55c932b85782a5687526b5 Mon Sep 17 00:00:00 2001 > > > From: Sean Christopherson > > > Date: Tue, 10 Dec 2019 15:24:32 -0800 > > > Subject: [PATCH] KVM: VMX: Add non-canonical check on writes to RTIT address > > > MSRs > > > > > > Reject writes to RTIT address MSRs if the data being written is a > > > non-canonical address as the MSRs are subject to canonical checks, e.g. > > > KVM will trigger an unchecked #GP when loading the values to hardware > > > during pt_guest_enter(). > > > > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Sean Christopherson > > > Signed-off-by: Paolo Bonzini > > > > File/code movement. Cleaned up and queued for 4.19-4.4. > > I don't know what happened here, but you've ended up adding the > entirety of arch/x86/kvm/vmx/vmx.c on all those branches rather than > applying the change to the right file. Oh wow that's wrong :( I'll go revert this, as it's not actually doing anything. Thanks for catching this. greg k-h