From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAF3C35640 for ; Fri, 21 Feb 2020 08:44:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 440A7206DB for ; Fri, 21 Feb 2020 08:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582274651; bh=bxhyd2uGL6csS55UfWR1JBrMopyybW97a+Q4pm8a5Do=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GcApLvZLMCTs0fIparZqiBf7t6NmCEX1pYSyDKCfQCiPqisnpYtd3XwZL+uUQQ4Ul Mrczi1sXLCslja6n7XaNFAEolApclG5oCUZGSdtNI4p0jkO5XzInVWjciwaXK0uvfa xQK/B/d3R6TEwupZGHlN9PECLWISIfD+2F6wl9zE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729934AbgBUHwn (ORCPT ); Fri, 21 Feb 2020 02:52:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:50650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729949AbgBUHwm (ORCPT ); Fri, 21 Feb 2020 02:52:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5130220801; Fri, 21 Feb 2020 07:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271561; bh=bxhyd2uGL6csS55UfWR1JBrMopyybW97a+Q4pm8a5Do=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eii1hgNbbscrI7kf1A9Yr8hqkQlTiXt2XLDKnat8R+vt8oAAza7AQii9427IzqlN0 NfNiNf2OJbpzYpIhkq0xUQcwezjDJD9oM9+YWKSap4tzdEhOuVI0dusf7G2iXvIGCb DZ0raSNFDVm5xhMMYQT8lwwstXz6EpuzuB0BV0Jw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jacob Pan , Eric Auger , Lu Baolu , Joerg Roedel , Sasha Levin Subject: [PATCH 5.5 213/399] iommu/vt-d: Avoid sending invalid page response Date: Fri, 21 Feb 2020 08:38:58 +0100 Message-Id: <20200221072423.704224194@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jacob Pan [ Upstream commit 5f75585e19cc7018bf2016aa771632081ee2f313 ] Page responses should only be sent when last page in group (LPIG) or private data is present in the page request. This patch avoids sending invalid descriptors. Fixes: 5d308fc1ecf53 ("iommu/vt-d: Add 256-bit invalidation descriptor support") Signed-off-by: Jacob Pan Reviewed-by: Eric Auger Signed-off-by: Lu Baolu Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/intel-svm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c index ff7a3f9add325..518d0b2d12afd 100644 --- a/drivers/iommu/intel-svm.c +++ b/drivers/iommu/intel-svm.c @@ -654,11 +654,10 @@ static irqreturn_t prq_event_thread(int irq, void *d) if (req->priv_data_present) memcpy(&resp.qw2, req->priv_data, sizeof(req->priv_data)); + resp.qw2 = 0; + resp.qw3 = 0; + qi_submit_sync(&resp, iommu); } - resp.qw2 = 0; - resp.qw3 = 0; - qi_submit_sync(&resp, iommu); - head = (head + sizeof(*req)) & PRQ_RING_MASK; } -- 2.20.1