From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: stable@vger.kernel.org, peter.chen@nxp.com,
mathias.nyman@linux.intel.com
Subject: Re: usb: host: xhci: update event ring dequeue pointer on purpose
Date: Wed, 26 Feb 2020 10:16:09 +0100 [thread overview]
Message-ID: <20200226091609.GA48573@kroah.com> (raw)
In-Reply-To: <20200220105209.27506-1-festevam@gmail.com>
On Thu, Feb 20, 2020 at 07:52:09AM -0300, Fabio Estevam wrote:
> From: Peter Chen <peter.chen@nxp.com>
>
> [ Upstream commit dc0ffbea5729a3abafa577ebfce87f18b79e294b ]
>
> On some situations, the software handles TRB events slower
> than adding TRBs, then xhci_handle_event can't return zero
> long time, the xHC will consider the event ring is full,
> and trigger "Event Ring Full" error, but in fact, the software
> has already finished lots of events, just no chance to
> update ERDP (event ring dequeue pointer).
>
> In this commit, we force update ERDP if half of TRBS_PER_SEGMENT
> events have handled to avoid "Event Ring Full" error.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> Link: https://lore.kernel.org/r/1573836603-10871-2-git-send-email-mathias.nyman@linux.intel.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi,
>
> One of our customer running 4.14 reported that this upstream patch
> fixes USB issues, so I am sending it to the stable trees.
It also needs to go to 4.19.y and 5.4.y, so I have added it there too.
thanks,
greg k-h
prev parent reply other threads:[~2020-02-26 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 10:52 usb: host: xhci: update event ring dequeue pointer on purpose Fabio Estevam
2020-02-26 9:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226091609.GA48573@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=festevam@gmail.com \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).