From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A77C4BA24 for ; Thu, 27 Feb 2020 02:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CB0224672 for ; Thu, 27 Feb 2020 02:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582771663; bh=4i7aNElgKb2KvKCQy1HtZ07hqhyKQxtLJ54PtxdBYvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iQVNcJa7MjVxz+nkwbGzfvsieyDTIfRzaZJD8lZMFda6tlW/nJIGfqzv8llRK7Hvn R/5mGpW0Ys9v1rBm3FiOROMDdwi6VqTrPJmPJ0/w86PrHVY1WkhKyVWtLBzcUa4luh SbnUex72sxXSXwn8pWgaYACFjyddTpnFBG9sbLpo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728298AbgB0Crk (ORCPT ); Wed, 26 Feb 2020 21:47:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:41694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728220AbgB0Crj (ORCPT ); Wed, 26 Feb 2020 21:47:39 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6611222C2; Thu, 27 Feb 2020 02:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582771659; bh=4i7aNElgKb2KvKCQy1HtZ07hqhyKQxtLJ54PtxdBYvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+dzYbUhFf9IUWEFHY8cGb+4FHG2ZDqI6899K3FBYJCLNJjxKtx+MPpIQn5ipbuer 6wi37OvUp2koF0Vqo5p/qKmqMgVf+V3QlUOAnNY5hDL2yZn5YZyLA+3sl8DGfEgthn snY3FD0kcL4/94DQXz/CArnUGVu9h++z8ySedJFA= Date: Wed, 26 Feb 2020 21:47:35 -0500 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: glider@google.com, akpm@linux-foundation.org, dvyukov@google.com, jpoimboe@redhat.com, kstewart@linuxfoundation.org, matthias.bgg@gmail.com, stable@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, walter-zh.wu@mediatek.com Subject: Re: FAILED: patch "[PATCH] lib/stackdepot.c: fix global out-of-bounds in stack_slabs" failed to apply to 4.19-stable tree Message-ID: <20200227024735.GE22178@sasha-vm> References: <1582714182242120@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1582714182242120@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Feb 26, 2020 at 11:49:42AM +0100, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 4.19-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From 305e519ce48e935702c32241f07d393c3c8fed3e Mon Sep 17 00:00:00 2001 >From: Alexander Potapenko >Date: Thu, 20 Feb 2020 20:04:30 -0800 >Subject: [PATCH] lib/stackdepot.c: fix global out-of-bounds in stack_slabs > >Walter Wu has reported a potential case in which init_stack_slab() is >called after stack_slabs[STACK_ALLOC_MAX_SLABS - 1] has already been >initialized. In that case init_stack_slab() will overwrite >stack_slabs[STACK_ALLOC_MAX_SLABS], which may result in a memory >corruption. > >Link: http://lkml.kernel.org/r/20200218102950.260263-1-glider@google.com >Fixes: cd11016e5f521 ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB") >Signed-off-by: Alexander Potapenko >Reported-by: Walter Wu >Cc: Dmitry Vyukov >Cc: Matthias Brugger >Cc: Thomas Gleixner >Cc: Josh Poimboeuf >Cc: Kate Stewart >Cc: Greg Kroah-Hartman >Cc: >Signed-off-by: Andrew Morton >Signed-off-by: Linus Torvalds I've grabbed ee050dc83bc3 ("lib/stackdepot: Fix outdated comments") as a dependency and queued for 4.19-4.9. Technically the comment change is wrong as the commit it addresses is older, but no one should be coding against the stable tree, and doing it by changing 305e519ce48e would cause merge conflicts in the future. -- Thanks, Sasha