From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3EAC34022 for ; Thu, 27 Feb 2020 14:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BBC124691 for ; Thu, 27 Feb 2020 14:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582814615; bh=NaNTqxtuUOQsOFP1anj/pHzM3OOymIE5IdFmt/ogCK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UZLqlUvk7+B5+tV3brlWrFhZR8cYni9s/CS7zKfsfEEpY2TWa1/rDlX59u02326R7 ogYKujJ2XlVYeju3nXN86hFs8ujbHOk3FWDOwpdlBBnriWJs1shbtqR3RScP+RAy/s dy9OC2xjke7Fyzxqicjv1iIrdsEpFjZUh5osPrHU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731053AbgB0Ntf (ORCPT ); Thu, 27 Feb 2020 08:49:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:47078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731050AbgB0Ntf (ORCPT ); Thu, 27 Feb 2020 08:49:35 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89D992469F; Thu, 27 Feb 2020 13:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582811375; bh=NaNTqxtuUOQsOFP1anj/pHzM3OOymIE5IdFmt/ogCK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uil1+/EayHTtQm3d3b1Hk7HoxONqUX1PZTaMXcFp1MLWaoWORIDaTlDrggUUZVllx FIknTuzzMPPVekReVZy+97ovl9mFJkvq170Fu/vfVA37FoI0LXxuQZ87Dd1ygEa1ac blBBCiYGKpuh1/5IxfRJ+Gtmm3Nfl27DXVqlB+HE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yunfeng Ye , zhengbin , Hu Shiyuan , Feilong Lin , Jan Kara , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.9 108/165] reiserfs: prevent NULL pointer dereference in reiserfs_insert_item() Date: Thu, 27 Feb 2020 14:36:22 +0100 Message-Id: <20200227132246.941130796@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132230.840899170@linuxfoundation.org> References: <20200227132230.840899170@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yunfeng Ye [ Upstream commit aacee5446a2a1aa35d0a49dab289552578657fb4 ] The variable inode may be NULL in reiserfs_insert_item(), but there is no check before accessing the member of inode. Fix this by adding NULL pointer check before calling reiserfs_debug(). Link: http://lkml.kernel.org/r/79c5135d-ff25-1cc9-4e99-9f572b88cc00@huawei.com Signed-off-by: Yunfeng Ye Cc: zhengbin Cc: Hu Shiyuan Cc: Feilong Lin Cc: Jan Kara Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/reiserfs/stree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index a97e352d05d3b..5f5fff0688776 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c @@ -2249,7 +2249,8 @@ error_out: /* also releases the path */ unfix_nodes(&s_ins_balance); #ifdef REISERQUOTA_DEBUG - reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, + if (inode) + reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, "reiserquota insert_item(): freeing %u id=%u type=%c", quota_bytes, inode->i_uid, head2type(ih)); #endif -- 2.20.1