From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A86C52D3B for ; Thu, 27 Feb 2020 14:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B886C24656 for ; Thu, 27 Feb 2020 14:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582814019; bh=xqQYtsCBrJ/YNM2yRYXqRKw+lJsnLhucMHS7wPD/g3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Na/tSxXSFf9y552dtylEvoFhLJ5PIVTAs0dK2kAapn9gYHEFZZx56sRGN1D7qkMaF FZqLuCyV8PMLIevcEqWhpssW/nVq+LyfptQBbRVh15ik1NXcb7sJ/9Axxs2P08NS2r 5x674IlKaq+YqPXHN+68vPxgXKEYIbpMLuhK2xzY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732708AbgB0OAP (ORCPT ); Thu, 27 Feb 2020 09:00:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:33584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732505AbgB0OAO (ORCPT ); Thu, 27 Feb 2020 09:00:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F17522084E; Thu, 27 Feb 2020 14:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812013; bh=xqQYtsCBrJ/YNM2yRYXqRKw+lJsnLhucMHS7wPD/g3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VcsiZ+ubndQKAktxsElzUojvFTtW8xSvNrYi0ZMj08/U2F2/TZZJ/mYu9bWV/M0xB xkya/AAtpco4DbKYY6hov+bUCDyuOdvsFXSjSREQa6RgOCnw88tL1tm6BUZlr2aVQD XdFomPgxJx86XPTrWUbJ2p7dgfcqwsaSCYH8F7vM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pietro Oliva , Larry Finger Subject: [PATCH 4.14 187/237] staging: rtl8188eu: Fix potential security hole Date: Thu, 27 Feb 2020 14:36:41 +0100 Message-Id: <20200227132310.098614919@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132255.285644406@linuxfoundation.org> References: <20200227132255.285644406@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Larry Finger commit 499c405b2b80bb3a04425ba3541d20305e014d3e upstream. In routine rtw_hostapd_ioctl(), the user-controlled p->length is assumed to be at least the size of struct ieee_param size, but this assumption is never checked. This could result in out-of-bounds read/write on kernel heap in case a p->length less than the size of struct ieee_param is specified by the user. If p->length is allowed to be greater than the size of the struct, then a malicious user could be wasting kernel memory. Fixes commit a2c60d42d97c ("Add files for new driver - part 16"). Reported by: Pietro Oliva Cc: Pietro Oliva Cc: Stable Fixes: a2c60d42d97c ("staging: r8188eu: Add files for new driver - part 16") Signed-off-by: Larry Finger Link: https://lore.kernel.org/r/20200210180235.21691-2-Larry.Finger@lwfinger.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -2856,7 +2856,7 @@ static int rtw_hostapd_ioctl(struct net_ goto out; } - if (!p->pointer) { + if (!p->pointer || p->length != sizeof(struct ieee_param)) { ret = -EINVAL; goto out; }