From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8E7C3F2D2 for ; Fri, 28 Feb 2020 16:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E775B246AC for ; Fri, 28 Feb 2020 16:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgB1Qsy (ORCPT ); Fri, 28 Feb 2020 11:48:54 -0500 Received: from foss.arm.com ([217.140.110.172]:41314 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgB1Qsx (ORCPT ); Fri, 28 Feb 2020 11:48:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6113031B; Fri, 28 Feb 2020 08:48:53 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5E293F73B; Fri, 28 Feb 2020 08:48:50 -0800 (PST) Date: Fri, 28 Feb 2020 16:48:48 +0000 From: Catalin Marinas To: Macpaul Lin Cc: Matthias Brugger , Shen Jing , Sasha Levin , John Stultz , Andrzej Pietrasiewicz , Vincent Pelletier , Jerry Zhang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Mediatek WSD Upstream , CC Hwang , Loda Chou , Al Viro , stable@vger.kernel.org, andreyknvl@google.com, Peter Chen , Miles Chen , eugenis@google.com Subject: Re: [PATCH v4] usb: gadget: f_fs: try to fix AIO issue under ARM 64 bit TAGGED mode Message-ID: <20200228164848.GH4019108@arrakis.emea.arm.com> References: <1582627315-21123-1-git-send-email-macpaul.lin@mediatek.com> <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582718512-28923-1-git-send-email-macpaul.lin@mediatek.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Feb 26, 2020 at 08:01:52PM +0800, Macpaul Lin wrote: > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index ce1d023..192935f 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -715,7 +715,20 @@ static void ffs_epfile_io_complete(struct usb_ep *_ep, struct usb_request *req) > > static ssize_t ffs_copy_to_iter(void *data, int data_len, struct iov_iter *iter) > { > - ssize_t ret = copy_to_iter(data, data_len, iter); > + ssize_t ret; > + > +#if defined(CONFIG_ARM64) > + /* > + * Replace tagged address passed by user space application before > + * copying. > + */ > + if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI) && > + (iter->type == ITER_IOVEC)) { > + *(unsigned long *)&iter->iov->iov_base = > + (unsigned long)untagged_addr(iter->iov->iov_base); > + } > +#endif > + ret = copy_to_iter(data, data_len, iter); > if (likely(ret == data_len)) > return ret; I had forgotten that we discussed a similar case already a few months ago (thanks to Evgenii for pointing out). Do you have this commit applied to your tree: df325e05a682 ("arm64: Validate tagged addresses in access_ok() called from kernel threads")? -- Catalin