From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADB2C3F2D3 for ; Fri, 28 Feb 2020 18:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5736B2469F for ; Fri, 28 Feb 2020 18:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582915006; bh=Zoi4OOCj5PUao03jw4sbw2xHe0PvXnrfJef5UgQ6+ro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=quC6+aff/W6L+AwqK1PilkbMq4MZm4GHdIgQGun4P72YqRXwiytnCvfLDd0ixZ4kU WV+IV6vju4yDFqLdI+NyUVR5o0AZ/GOcZYw7EbCTHuRiYWWhLkLa2AyZRiNCSs6HVp OynN90pRjnRF/kq555Nk5E+B0I4fpXt3Fsss4VMA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbgB1Sgp (ORCPT ); Fri, 28 Feb 2020 13:36:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:38914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgB1Sgp (ORCPT ); Fri, 28 Feb 2020 13:36:45 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79CC524677; Fri, 28 Feb 2020 18:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582915004; bh=Zoi4OOCj5PUao03jw4sbw2xHe0PvXnrfJef5UgQ6+ro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZuRNCPAcqVWapY9nzOqoJd0r76VqKIspN4RPY9Fe5hLP2Q0f+epZ3czPZG699zymd c66bsDTjyKKhxJNDzw5cGcvTei8IuuoabIlVPoLn/6j+HlX3G8E+2iM7XeAp/uZAdq VsKh8NdLt+/v9yy/yIfzvSve7ZGWStanPJGOJjfg= Date: Fri, 28 Feb 2020 13:36:43 -0500 From: Sasha Levin To: Kurt Kanzenbach Cc: Andy Shevchenko , gregkh@linuxfoundation.org, lirongqing@baidu.com, stable@vger.kernel.org, vikram.pandita@ti.com Subject: Re: FAILED: patch "[PATCH] serial: 8250: Check UPF_IRQ_SHARED in advance" failed to apply to 4.14-stable tree Message-ID: <20200228183643.GB21491@sasha-vm> References: <158271336456142@kroah.com> <20200226233949.GC22178@sasha-vm> <20200227095908.GC1224808@smile.fi.intel.com> <87r1yf2j57.fsf@kurt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87r1yf2j57.fsf@kurt> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 28, 2020 at 09:47:16AM +0100, Kurt Kanzenbach wrote: >Hi, > >On Thu Feb 27 2020, Andy Shevchenko wrote: >> On Wed, Feb 26, 2020 at 06:39:49PM -0500, Sasha Levin wrote: >>> On Wed, Feb 26, 2020 at 11:36:04AM +0100, gregkh@linuxfoundation.org wrote: >> >> ... >> >>> > Since this change we don't need to have custom solutions in 8250_aspeed_vuart >>> > and 8250_of drivers, thus, drop them. >>> > >>> > Fixes: 1c2f04937b3e ("serial: 8250: add IRQ trigger support") >>> > Reported-by: Li RongQing >>> > Cc: Kurt Kanzenbach >>> > Cc: Vikram Pandita >>> > Signed-off-by: Andy Shevchenko >>> > Cc: stable >>> > Acked-by: Kurt Kanzenbach >>> > Link: https://lore.kernel.org/r/20200211135559.85960-1-andriy.shevchenko@linux.intel.com >>> > Signed-off-by: Greg Kroah-Hartman >>> >>> For 4.14, I've worked around these missing commits: >>> >>> 5909c0bf9c7a ("serial/aspeed-vuart: Implement quick throttle mechanism") >>> 989983ea849d ("serial/aspeed-vuart: Implement rx throttling") >>> 54e53b2e8081 ("tty: serial: 8250: pass IRQ shared flag to UART ports") >> >> Thanks! >> >>> And queued up a backport. Older kernels are a bit trickier than that. > >Thanks for backporting. Why is it trickier? > >> >> Since it's quite old bug and not many reports so far I guess we are not in >> hurry to fix that old kernels. > >It would be quite nice to have that in v4.9 as well. My original patch >was made against that tree and tested. Hm, yes, looking at it now it doesn't look too tricky, I'm not sure what happened a few days ago :) If you want to send me a backport I'll be happy to queue it up. -- Thanks, Sasha