From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA2BC3F2CE for ; Sat, 29 Feb 2020 03:46:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B1E4246AE for ; Sat, 29 Feb 2020 03:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582947994; bh=8/1smc8j49MqGwnYGm26WRCBSJWhdGq3Kci/+iykrSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QuKZ9zTs74GTCFV28tEV0UTs/nI6EQ9hXhE18J3QbHss4CPX3SXm78s/jo/58dFGI LedAmIe9wzQgkKYiICoK0xC18skjKr2Tyu/O67iWFKeXKRMX0EVM1TmjNjy+SOlPG/ lh9hcdlR6G7ydAc9jXimeQVNprOAuMhR1zzcFEjk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgB2Dqd (ORCPT ); Fri, 28 Feb 2020 22:46:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:34490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgB2Dqd (ORCPT ); Fri, 28 Feb 2020 22:46:33 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9291B246A2; Sat, 29 Feb 2020 03:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582947992; bh=8/1smc8j49MqGwnYGm26WRCBSJWhdGq3Kci/+iykrSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fxl3/WvriTf1bPawKq/fakfqWDP7xNiZ9q2n81QEpCC2VqfIXzfzZBzMYIevtKdar l8dE+NaRFs76WuF4/klGRkJpGjwjRj1RCOO2duaOnAf3uw/S+Pb7HUhcGSNafPQ8CB ZdYL8o9L2kUmpwTaKgIQjUVxfkKISrLyinPt8MgI= Date: Fri, 28 Feb 2020 22:46:31 -0500 From: Sasha Levin To: Joe Perches Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nathan Chancellor Subject: Re: [PATCH 4.14 111/237] tty: synclinkmp: Adjust indentation in several functions Message-ID: <20200229034631.GH21491@sasha-vm> References: <20200227132255.285644406@linuxfoundation.org> <20200227132305.054909944@linuxfoundation.org> <11c17de7c525997ddddab995223828bdec8e8e93.camel@perches.com> <20200228071239.GC2895159@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 28, 2020 at 10:06:45AM -0800, Joe Perches wrote: >On Fri, 2020-02-28 at 08:12 +0100, Greg Kroah-Hartman wrote: >> On Thu, Feb 27, 2020 at 07:55:49PM -0800, Joe Perches wrote: >> > On Thu, 2020-02-27 at 14:35 +0100, Greg Kroah-Hartman wrote: >> > > From: Nathan Chancellor >> > >> > I believe these sorts of whitespace only changes should >> > not be applied to a stable branch unless it's useful for >> > porting other actual defect fixes. >> >> I want to get clang build warnings down to the same level that gcc build >> warnings are, so that they become useful in detecting new issues. That >> is why I add these types of patches to the stable trees. > >New issues should be found in the current kernel. Right, but we're talking about issues with backporting patches. We catch a lot of issues where a patch applied to an older version, but is missing stuff or is outright incorrect by having the compiler warn us about it. We're not trying to debug upstream, but rather to catch broken backports that compile but are broken. >Backporting whitespace changes is value-free. The value here is to make other errors obvious. -- Thanks, Sasha