From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCA7C3F2D8 for ; Tue, 3 Mar 2020 18:09:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E290208C3 for ; Tue, 3 Mar 2020 18:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258972; bh=KjgFi/6YT/H1W0J/f5IdJMe0Gr2e1J10/BXIEZG8s0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JELRd3cglOiT6VB9SUlxMBNRGXyAYqGCrxCyQruoSmlvnmPwWDvASjk9ADol001jK 4TQraU9QZ6kGZWPILHBfC9uADE6C6gnXNX/Tw2LZ3uHoA6/cGQYg6Gn2oEH9xFbvoq UxT/b44k/adiIm+LEGk58g3gnJIyuO2WOzfLXAgw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732129AbgCCRwT (ORCPT ); Tue, 3 Mar 2020 12:52:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:60672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731275AbgCCRwS (ORCPT ); Tue, 3 Mar 2020 12:52:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9046424671; Tue, 3 Mar 2020 17:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583257938; bh=KjgFi/6YT/H1W0J/f5IdJMe0Gr2e1J10/BXIEZG8s0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hplU/+RD1uJExG3C52rhkMI3Efj2yD7VUcFiC9CQvKK3Wym9F6GKPHYPxP5LErMhQ vl3RIi3C1VPutxsJgyjiCtT5AKFA7xNRzHgxJjlONcC+duwMQagSDlk8gMtDyaec3B 1GBkX/jFlzMJ12/5flwu02d1oUslIPycdR4bJbPY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aristeu Rozanski , Tony Luck , Sasha Levin Subject: [PATCH 5.4 002/152] EDAC: skx_common: downgrade message importance on missing PCI device Date: Tue, 3 Mar 2020 18:41:40 +0100 Message-Id: <20200303174302.813659020@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200303174302.523080016@linuxfoundation.org> References: <20200303174302.523080016@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Aristeu Rozanski [ Upstream commit 854bb48018d5da261d438b2232fa683bdb553979 ] Both skx_edac and i10nm_edac drivers are loaded based on the matching CPU being available which leads the module to be automatically loaded in virtual machines as well. That will fail due the missing PCI devices. In both drivers the first function to make use of the PCI devices is skx_get_hi_lo() will simply print EDAC skx: Can't get tolm/tohm for each CPU core, which is noisy. This patch makes it a debug message. Signed-off-by: Aristeu Rozanski Signed-off-by: Tony Luck Link: https://lore.kernel.org/r/20191204212325.c4k47p5hrnn3vpb5@redhat.com Signed-off-by: Sasha Levin --- drivers/edac/skx_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c index d8ff63d91b860..a04349c6d17ef 100644 --- a/drivers/edac/skx_common.c +++ b/drivers/edac/skx_common.c @@ -235,7 +235,7 @@ int skx_get_hi_lo(unsigned int did, int off[], u64 *tolm, u64 *tohm) pdev = pci_get_device(PCI_VENDOR_ID_INTEL, did, NULL); if (!pdev) { - skx_printk(KERN_ERR, "Can't get tolm/tohm\n"); + edac_dbg(2, "Can't get tolm/tohm\n"); return -ENODEV; } -- 2.20.1