From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D49C3F2D1 for ; Wed, 4 Mar 2020 11:52:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CC2C21739 for ; Wed, 4 Mar 2020 11:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583322756; bh=q23mTk/ZAOBsw/eSwIFmK8jNOKlKiuyyRBvn/yfvHmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HN8tnNAGCKMSMkV81gRw9MQk2hnFDde++oXbyKp8j/3RAjg2SNUYdqBx1F4SyK0Bz uJ9Bd+4Qb00ROxwi81ePmjK0wn+0zcuNKoPXOcGeqx49F83MUUnl3ivp1aMYGcaypM 0sJooYY5B+HlwTg8399F8OFqIiZ9y5WYqaCZNEQA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729275AbgCDLwf (ORCPT ); Wed, 4 Mar 2020 06:52:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:35232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbgCDLwf (ORCPT ); Wed, 4 Mar 2020 06:52:35 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39C1A20842; Wed, 4 Mar 2020 11:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583322754; bh=q23mTk/ZAOBsw/eSwIFmK8jNOKlKiuyyRBvn/yfvHmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1RmV4Aysd40GTtxVKsyXYyvR3qXIMSU+kUXkTUqA5orBs+kH9kY0t0rdLaC5SD0PW 2dOyldWSD36ZWtSHOJGNvoD3b/RPXt8rmCZdoML0cLngF9OOnbLFJMJ0Bt00zhjpYR AsAO6kFwgNCzwKFgkNx/qLDxZ4iBT3wwOoslOOt4= Date: Wed, 4 Mar 2020 12:52:32 +0100 From: Greg Kroah-Hartman To: Naresh Kamboju Cc: open list , Shuah Khan , patches@kernelci.org, lkft-triage@lists.linaro.org, Ben Hutchings , linux- stable , Andrew Morton , Linus Torvalds , Guenter Roeck Subject: Re: [PATCH 5.5 000/176] 5.5.8-stable review Message-ID: <20200304115232.GC1581141@kroah.com> References: <20200303174304.593872177@linuxfoundation.org> <20200304081128.GC1401372@kroah.com> <20200304084702.GA1416015@kroah.com> <20200304084946.GB1416015@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 04, 2020 at 04:22:30PM +0530, Naresh Kamboju wrote: > On Wed, 4 Mar 2020 at 14:19, Greg Kroah-Hartman > wrote: > > > > On Wed, Mar 04, 2020 at 09:47:02AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Mar 04, 2020 at 09:11:28AM +0100, Greg Kroah-Hartman wrote: > > > > On Wed, Mar 04, 2020 at 12:43:42PM +0530, Naresh Kamboju wrote: > > > > > On Tue, 3 Mar 2020 at 23:16, Greg Kroah-Hartman > > > > > wrote: > > > > > > > > > > > > This is the start of the stable review cycle for the 5.5.8 release. > > > > > > There are 176 patches in this series, all will be posted as a response > > > > > > to this one. If anyone has any issues with these being applied, please > > > > > > let me know. > > > > > > > > > > > > Responses should be made by Thu, 05 Mar 2020 17:42:06 +0000. > > > > > > Anything received after that time might be too late. > > > > > > > > > > > > The whole patch series can be found in one patch at: > > > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.8-rc1.gz > > > > > > or in the git tree and branch at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y > > > > > > and the diffstat can be found below. > > > > > > > > > > > > thanks, > > > > > > > > > > > > greg k-h > > > > > > > > > > > > > > > > Results from Linaro’s test farm. > > > > > Regressions detected on x86_64 and i386. > > > > > > > > > > Test failure output: > > > > > CVE-2017-5715: VULN (IBRS+IBPB or retpoline+IBPB+RSB filling, is > > > > > needed to mitigate the vulnerability) > > > > > > > > > > Test description: > > > > > CVE-2017-5715 branch target injection (Spectre Variant 2) > > > > > > > > > > Impact: Kernel > > > > > Mitigation 1: new opcode via microcode update that should be used by > > > > > up to date compilers to protect the BTB (by flushing indirect branch > > > > > predictors) > > > > > Mitigation 2: introducing "retpoline" into compilers, and recompile > > > > > software/OS with it > > > > > Performance impact of the mitigation: high for mitigation 1, medium > > > > > for mitigation 2, depending on your CPU > > > > > > > > So these are regressions or just new tests? > > > > > > > > If regressions, can you do 'git bisect' to find the offending commit? > > > > > > > > Also, are you sure you have an updated microcode on these machines and a > > > > proper compiler for retpoline? > > > > > > As an example of just how crazy that script is, here's the output of my > > > machine for that first CVE issue: > > > > > > CVE-2017-5715 aka 'Spectre Variant 2, branch target injection' > > > * Mitigated according to the /sys interface: YES (Mitigation: Full generic retpoline, IBPB: conditional, IBRS_FW, STIBP: conditional, RSB filling) > > > * Mitigation 1 > > > * Kernel is compiled with IBRS support: YES > > > * IBRS enabled and active: YES (for firmware code only) > > > * Kernel is compiled with IBPB support: YES > > > * IBPB enabled and active: YES > > > * Mitigation 2 > > > * Kernel has branch predictor hardening (arm): NO > > > * Kernel compiled with retpoline option: YES > > > * Kernel compiled with a retpoline-aware compiler: YES (kernel reports full retpoline compilation) > > > * Kernel supports RSB filling: UNKNOWN (couldn't check (couldn't find your kernel image in /boot, if you used netboot, this is normal)) > > > > STATUS: VULNERABLE (IBRS+IBPB or retpoline+IBPB+RSB filling, is needed to mitigate > > > > > > So why is this "Vulnerable"? Because it didn't think it could find my > > > kernel image for some odd reason, despite it really being in /boot/ (I > > > don't use netboot) > > Now I know the real reason why this test failed. > With this note we can conclude this is not a regression. > > No regressions on arm64, arm, x86_64, and i386 for 4.19, 5.4 and 5.5 branches. Great, thanks for confirming and for testing all of these. greg k-h