* Re: [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation [not found] <202003051623.AF4F8CB@keescook> @ 2020-03-07 23:20 ` Sasha Levin 2020-03-08 21:51 ` Kees Cook 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2020-03-07 23:20 UTC (permalink / raw) To: Sasha Levin, Kees Cook, Andrew Morton Cc: Christoph Lameter, Pekka Enberg, stable, stable [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain, Size: 1008 bytes --] Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 2482ddec670f ("mm: add SLUB free list pointer obfuscation"). The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172. v5.5.8: Build failed! Errors: mm/slub.c:262:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration] v5.4.24: Build failed! Errors: mm/slub.c:264:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration] v4.19.108: Failed to apply! Possible dependencies: d36a63a943e3 ("kasan, slub: fix more conflicts with CONFIG_SLAB_FREELIST_HARDENED") v4.14.172: Failed to apply! Possible dependencies: d36a63a943e3 ("kasan, slub: fix more conflicts with CONFIG_SLAB_FREELIST_HARDENED") NOTE: The patch will not be queued to stable trees until it is upstream. How should we proceed with this patch? -- Thanks Sasha ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation 2020-03-07 23:20 ` [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation Sasha Levin @ 2020-03-08 21:51 ` Kees Cook 2020-03-09 0:51 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Kees Cook @ 2020-03-08 21:51 UTC (permalink / raw) To: Sasha Levin; +Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, stable On Sat, Mar 07, 2020 at 11:20:37PM +0000, Sasha Levin wrote: > Hi > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag > fixing commit: 2482ddec670f ("mm: add SLUB free list pointer obfuscation"). > > The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172. > > v5.5.8: Build failed! Errors: > mm/slub.c:262:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration] > Eek; this must be missing an include that is implicit from something recent? I will investigate... -Kees > v5.4.24: Build failed! Errors: > mm/slub.c:264:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration] > > v4.19.108: Failed to apply! Possible dependencies: > d36a63a943e3 ("kasan, slub: fix more conflicts with CONFIG_SLAB_FREELIST_HARDENED") > > v4.14.172: Failed to apply! Possible dependencies: > d36a63a943e3 ("kasan, slub: fix more conflicts with CONFIG_SLAB_FREELIST_HARDENED") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? > > -- > Thanks > Sasha -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation 2020-03-08 21:51 ` Kees Cook @ 2020-03-09 0:51 ` Sasha Levin 2020-03-09 16:41 ` Kees Cook 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2020-03-09 0:51 UTC (permalink / raw) To: Kees Cook; +Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, stable On Sun, Mar 08, 2020 at 02:51:27PM -0700, Kees Cook wrote: >On Sat, Mar 07, 2020 at 11:20:37PM +0000, Sasha Levin wrote: >> Hi >> >> [This is an automated email] >> >> This commit has been processed because it contains a "Fixes:" tag >> fixing commit: 2482ddec670f ("mm: add SLUB free list pointer obfuscation"). >> >> The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172. >> >> v5.5.8: Build failed! Errors: >> mm/slub.c:262:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration] >> > >Eek; this must be missing an include that is implicit from something >recent? I will investigate... swab() didn't exist "back then" :) It was introduced by d5767057c9a7 ("uapi: rename ext2_swab() to swab() and share globally in swab.h"). I can just take that patch to stable kernels. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation 2020-03-09 0:51 ` Sasha Levin @ 2020-03-09 16:41 ` Kees Cook 0 siblings, 0 replies; 4+ messages in thread From: Kees Cook @ 2020-03-09 16:41 UTC (permalink / raw) To: Sasha Levin; +Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, stable On Sun, Mar 08, 2020 at 08:51:12PM -0400, Sasha Levin wrote: > On Sun, Mar 08, 2020 at 02:51:27PM -0700, Kees Cook wrote: > > On Sat, Mar 07, 2020 at 11:20:37PM +0000, Sasha Levin wrote: > > > Hi > > > > > > [This is an automated email] > > > > > > This commit has been processed because it contains a "Fixes:" tag > > > fixing commit: 2482ddec670f ("mm: add SLUB free list pointer obfuscation"). > > > > > > The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172. > > > > > > v5.5.8: Build failed! Errors: > > > mm/slub.c:262:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration] > > > > > > > Eek; this must be missing an include that is implicit from something > > recent? I will investigate... > > swab() didn't exist "back then" :) It was introduced by d5767057c9a7 > ("uapi: rename ext2_swab() to swab() and share globally in swab.h"). I > can just take that patch to stable kernels. Ah, perfect. Yes, that would be very nice. -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-09 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202003051623.AF4F8CB@keescook>
2020-03-07 23:20 ` [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation Sasha Levin
2020-03-08 21:51 ` Kees Cook
2020-03-09 0:51 ` Sasha Levin
2020-03-09 16:41 ` Kees Cook
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).