From: Greg KH <gregkh@linuxfoundation.org>
To: Dragos Tarcatu <dragos_tarcatu@mentor.com>
Cc: broonie@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4.14] ASoC: topology: Fix memleak in soc_tplg_manifest_load()
Date: Tue, 10 Mar 2020 15:44:04 +0100 [thread overview]
Message-ID: <20200310144404.GD3376131@kroah.com> (raw)
In-Reply-To: <20200310140211.25468-1-dragos_tarcatu@mentor.com>
On Tue, Mar 10, 2020 at 04:02:11PM +0200, Dragos Tarcatu wrote:
> commit 242c46c023610dbc0213fc8fb6b71eb836bc5d95 upstream.
>
> In case of ABI version mismatch, _manifest needs to be freed as
> it is just a copy of the original topology manifest. However, if
> a driver manifest handler is defined, that would get executed and
> the cleanup is never reached. Fix that by getting the return status
> of manifest() instead of returning directly.
>
> Fixes: 583958fa2e52 ("ASoC: topology: Make manifest backward compatible from ABI v4")
> Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
> Link: https://lore.kernel.org/r/20200207185325.22320-3-dragos_tarcatu@mentor.com
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> sound/soc/soc-topology.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Thanks for the backport, now queued up.
greg k-h
prev parent reply other threads:[~2020-03-10 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 20:35 FAILED: patch "[PATCH] ASoC: topology: Fix memleak in soc_tplg_manifest_load()" failed to apply to 4.14-stable tree gregkh
2020-03-10 14:02 ` [PATCH v4.14] ASoC: topology: Fix memleak in soc_tplg_manifest_load() Dragos Tarcatu
2020-03-10 14:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310144404.GD3376131@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=dragos_tarcatu@mentor.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).