* [PATCH] ARM: dts: exynos: Fix polarity of the LCD SPI bus on UniversalC210 board [not found] <CGME20200304143756eucas1p1557bba245d3b9878cd2adc970e6d58f6@eucas1p1.samsung.com> @ 2020-03-04 14:37 ` Marek Szyprowski 2020-03-09 8:40 ` Andrzej Hajda 2020-03-11 10:04 ` Krzysztof Kozlowski 0 siblings, 2 replies; 3+ messages in thread From: Marek Szyprowski @ 2020-03-04 14:37 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, stable Recent changes in the SPI core and the SPI-GPIO driver revealed that the GPIO lines for the LD9040 LCD controller on the UniversalC210 board are defined incorrectly. Fix the polarity for those lines to match the old behavior and hardware requirements to fix LCD panel operation with recent kernels. CC: stable@vger.kernel.org # 5.0+ Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts index a1bdf7830a87..9dda6bdb9253 100644 --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts @@ -115,7 +115,7 @@ gpio-sck = <&gpy3 1 GPIO_ACTIVE_HIGH>; gpio-mosi = <&gpy3 3 GPIO_ACTIVE_HIGH>; num-chipselects = <1>; - cs-gpios = <&gpy4 3 GPIO_ACTIVE_HIGH>; + cs-gpios = <&gpy4 3 GPIO_ACTIVE_LOW>; lcd@0 { compatible = "samsung,ld9040"; @@ -124,8 +124,6 @@ vci-supply = <&ldo17_reg>; reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>; spi-max-frequency = <1200000>; - spi-cpol; - spi-cpha; power-on-delay = <10>; reset-delay = <10>; panel-width-mm = <90>; -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Fix polarity of the LCD SPI bus on UniversalC210 board 2020-03-04 14:37 ` [PATCH] ARM: dts: exynos: Fix polarity of the LCD SPI bus on UniversalC210 board Marek Szyprowski @ 2020-03-09 8:40 ` Andrzej Hajda 2020-03-11 10:04 ` Krzysztof Kozlowski 1 sibling, 0 replies; 3+ messages in thread From: Andrzej Hajda @ 2020-03-09 8:40 UTC (permalink / raw) To: Marek Szyprowski, linux-samsung-soc Cc: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, stable On 04.03.2020 15:37, Marek Szyprowski wrote: > Recent changes in the SPI core and the SPI-GPIO driver revealed that the > GPIO lines for the LD9040 LCD controller on the UniversalC210 board are > defined incorrectly. Fix the polarity for those lines to match the old > behavior and hardware requirements to fix LCD panel operation with > recent kernels. > > CC: stable@vger.kernel.org # 5.0+ > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > --- > arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts > index a1bdf7830a87..9dda6bdb9253 100644 > --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts > +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts > @@ -115,7 +115,7 @@ > gpio-sck = <&gpy3 1 GPIO_ACTIVE_HIGH>; > gpio-mosi = <&gpy3 3 GPIO_ACTIVE_HIGH>; > num-chipselects = <1>; > - cs-gpios = <&gpy4 3 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpy4 3 GPIO_ACTIVE_LOW>; > > lcd@0 { > compatible = "samsung,ld9040"; > @@ -124,8 +124,6 @@ > vci-supply = <&ldo17_reg>; > reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>; > spi-max-frequency = <1200000>; > - spi-cpol; > - spi-cpha; > power-on-delay = <10>; > reset-delay = <10>; > panel-width-mm = <90>; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Fix polarity of the LCD SPI bus on UniversalC210 board 2020-03-04 14:37 ` [PATCH] ARM: dts: exynos: Fix polarity of the LCD SPI bus on UniversalC210 board Marek Szyprowski 2020-03-09 8:40 ` Andrzej Hajda @ 2020-03-11 10:04 ` Krzysztof Kozlowski 1 sibling, 0 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2020-03-11 10:04 UTC (permalink / raw) To: Marek Szyprowski; +Cc: linux-samsung-soc, Bartlomiej Zolnierkiewicz, stable On Wed, Mar 04, 2020 at 03:37:26PM +0100, Marek Szyprowski wrote: > Recent changes in the SPI core and the SPI-GPIO driver revealed that the > GPIO lines for the LD9040 LCD controller on the UniversalC210 board are > defined incorrectly. Fix the polarity for those lines to match the old > behavior and hardware requirements to fix LCD panel operation with > recent kernels. > > CC: stable@vger.kernel.org # 5.0+ Thanks, applied (with slightly adjusted Cc-stable format, as in documentation). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-11 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200304143756eucas1p1557bba245d3b9878cd2adc970e6d58f6@eucas1p1.samsung.com>
2020-03-04 14:37 ` [PATCH] ARM: dts: exynos: Fix polarity of the LCD SPI bus on UniversalC210 board Marek Szyprowski
2020-03-09 8:40 ` Andrzej Hajda
2020-03-11 10:04 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).