* [PATCH] rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44
@ 2020-02-19 20:00 Larry Finger
2020-03-12 13:31 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2020-02-19 20:00 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, pkshih, Larry Finger, Stable, Ashish
For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee:
Remove local configuration variable") broke at least one system. As
the only net effect of the change was to remove 2 bytes from the start
of struct phy_status_rpt, this patch adds 2 bytes of padding at the
beginning of the struct.
Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable")
Cc: Stable <stable@vger.kernel.org> # V5.4+
Reported-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
Tested-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
index 917729807514..e17f70b4d199 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
@@ -561,6 +561,7 @@ static inline void clear_pci_tx_desc_content(__le32 *__pdesc, int _size)
rxmcs == DESC92C_RATE11M)
struct phy_status_rpt {
+ u8 padding[2];
u8 ch_corr[2];
u8 cck_sig_qual_ofdm_pwdb_all;
u8 cck_agc_rpt_ofdm_cfosho_a;
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44
2020-02-19 20:00 [PATCH] rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44 Larry Finger
@ 2020-03-12 13:31 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-03-12 13:31 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger, Stable, Ashish
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee:
> Remove local configuration variable") broke at least one system. As
> the only net effect of the change was to remove 2 bytes from the start
> of struct phy_status_rpt, this patch adds 2 bytes of padding at the
> beginning of the struct.
>
> Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable")
> Cc: Stable <stable@vger.kernel.org> # V5.4+
> Reported-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
> Tested-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers.git, thanks.
c80b18cbb04b rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44
--
https://patchwork.kernel.org/patch/11392353/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-19 20:00 [PATCH] rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44 Larry Finger
2020-03-12 13:31 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).