* Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue [not found] ` <20200105.144704.221506192255563950.davem@davemloft.net> @ 2020-02-25 22:52 ` Doug Anderson 2020-02-27 4:28 ` David Miller 2020-03-17 10:26 ` Greg KH 0 siblings, 2 replies; 5+ messages in thread From: Doug Anderson @ 2020-02-25 22:52 UTC (permalink / raw) To: stable@vger.kernel.org; +Cc: Wen Gong, netdev, LKML, ath11k, David Miller Hi, On Sun, Jan 5, 2020 at 2:47 PM David Miller <davem@davemloft.net> wrote: > > From: Wen Gong <wgong@codeaurora.org> > Date: Fri, 3 Jan 2020 12:50:16 +0800 > > > The len used for skb_put_padto is wrong, it need to add len of hdr. > > Thanks, applied. I noticed this patch is in mainline now as: ce57785bf91b net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue Though I'm not an expert on the code, it feels like a stable candidate unless someone objects. -Doug ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue 2020-02-25 22:52 ` [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue Doug Anderson @ 2020-02-27 4:28 ` David Miller 2020-03-17 10:26 ` Greg KH 1 sibling, 0 replies; 5+ messages in thread From: David Miller @ 2020-02-27 4:28 UTC (permalink / raw) To: dianders; +Cc: stable, wgong, netdev, linux-kernel, ath11k From: Doug Anderson <dianders@chromium.org> Date: Tue, 25 Feb 2020 14:52:24 -0800 > I noticed this patch is in mainline now as: > > ce57785bf91b net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue > > Though I'm not an expert on the code, it feels like a stable candidate > unless someone objects. Ok, queued up, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue 2020-02-25 22:52 ` [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue Doug Anderson 2020-02-27 4:28 ` David Miller @ 2020-03-17 10:26 ` Greg KH 2020-03-17 15:45 ` Doug Anderson 1 sibling, 1 reply; 5+ messages in thread From: Greg KH @ 2020-03-17 10:26 UTC (permalink / raw) To: Doug Anderson Cc: stable@vger.kernel.org, Wen Gong, netdev, LKML, ath11k, David Miller On Tue, Feb 25, 2020 at 02:52:24PM -0800, Doug Anderson wrote: > Hi, > > > On Sun, Jan 5, 2020 at 2:47 PM David Miller <davem@davemloft.net> wrote: > > > > From: Wen Gong <wgong@codeaurora.org> > > Date: Fri, 3 Jan 2020 12:50:16 +0800 > > > > > The len used for skb_put_padto is wrong, it need to add len of hdr. > > > > Thanks, applied. > > I noticed this patch is in mainline now as: > > ce57785bf91b net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue > > Though I'm not an expert on the code, it feels like a stable candidate > unless someone objects. Stable candidate for what tree(s)? thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue 2020-03-17 10:26 ` Greg KH @ 2020-03-17 15:45 ` Doug Anderson 2020-03-19 7:46 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Doug Anderson @ 2020-03-17 15:45 UTC (permalink / raw) To: Greg KH Cc: stable@vger.kernel.org, Wen Gong, netdev, LKML, ath11k, David Miller Hi, On Tue, Mar 17, 2020 at 3:26 AM Greg KH <greg@kroah.com> wrote: > > On Tue, Feb 25, 2020 at 02:52:24PM -0800, Doug Anderson wrote: > > Hi, > > > > > > On Sun, Jan 5, 2020 at 2:47 PM David Miller <davem@davemloft.net> wrote: > > > > > > From: Wen Gong <wgong@codeaurora.org> > > > Date: Fri, 3 Jan 2020 12:50:16 +0800 > > > > > > > The len used for skb_put_padto is wrong, it need to add len of hdr. > > > > > > Thanks, applied. > > > > I noticed this patch is in mainline now as: > > > > ce57785bf91b net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue > > > > Though I'm not an expert on the code, it feels like a stable candidate > > unless someone objects. > > Stable candidate for what tree(s)? I noticed that it was lacking and applied cleanly on 5.4. As of 5.4.25 it's still not stable there. I only noticed it because I was comparing all the patches in mainline in "net/qrtr" with what we had in our tree and stumbled upon this one. Looking at it a little more carefully, I guess you could say: Fixes: e7044482c8ac ("net: qrtr: Pass source and destination to enqueue functions") ...though it will be trickier to apply past commit 194ccc88297a ("net: qrtr: Support decoding incoming v2 packets") just because the math changed. -Doug ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue 2020-03-17 15:45 ` Doug Anderson @ 2020-03-19 7:46 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2020-03-19 7:46 UTC (permalink / raw) To: Doug Anderson Cc: stable@vger.kernel.org, Wen Gong, netdev, LKML, ath11k, David Miller On Tue, Mar 17, 2020 at 08:45:09AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Mar 17, 2020 at 3:26 AM Greg KH <greg@kroah.com> wrote: > > > > On Tue, Feb 25, 2020 at 02:52:24PM -0800, Doug Anderson wrote: > > > Hi, > > > > > > > > > On Sun, Jan 5, 2020 at 2:47 PM David Miller <davem@davemloft.net> wrote: > > > > > > > > From: Wen Gong <wgong@codeaurora.org> > > > > Date: Fri, 3 Jan 2020 12:50:16 +0800 > > > > > > > > > The len used for skb_put_padto is wrong, it need to add len of hdr. > > > > > > > > Thanks, applied. > > > > > > I noticed this patch is in mainline now as: > > > > > > ce57785bf91b net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue > > > > > > Though I'm not an expert on the code, it feels like a stable candidate > > > unless someone objects. > > > > Stable candidate for what tree(s)? > > I noticed that it was lacking and applied cleanly on 5.4. As of > 5.4.25 it's still not stable there. I only noticed it because I was > comparing all the patches in mainline in "net/qrtr" with what we had > in our tree and stumbled upon this one. > > Looking at it a little more carefully, I guess you could say: > > Fixes: e7044482c8ac ("net: qrtr: Pass source and destination to > enqueue functions") > > ...though it will be trickier to apply past commit 194ccc88297a ("net: > qrtr: Support decoding incoming v2 packets") just because the math > changed. Given that both of those commits showed up in 4.15, it doesn't matter much :) I've queued this up for 5.4.y and 4.19.y now, thanks. greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-19 7:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200103045016.12459-1-wgong@codeaurora.org>
[not found] ` <20200105.144704.221506192255563950.davem@davemloft.net>
2020-02-25 22:52 ` [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue Doug Anderson
2020-02-27 4:28 ` David Miller
2020-03-17 10:26 ` Greg KH
2020-03-17 15:45 ` Doug Anderson
2020-03-19 7:46 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).