From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E119C10F29 for ; Tue, 17 Mar 2020 10:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63C5220714 for ; Tue, 17 Mar 2020 10:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584442731; bh=UzxYSHzk2tW0gJ25zVESWN3tdPqPC6wHiWDbCCRoygE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o3rHITIGgw6t1/GJxdfEkaauneJENhoImIiX4ZYogeZsJCQ5SAZVWLH1tn/aAoFF7 YAq8Aete6dtucHIeZf4jVSo29SChN9OKfH0YUrgzuigcI+//BZOzE4oi4D3GANGjWi Pzg6TbP6sv/wNhZS6HI9z/iDgzM+J1trMHrRhNsU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727320AbgCQK6r (ORCPT ); Tue, 17 Mar 2020 06:58:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:37018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727318AbgCQK6q (ORCPT ); Tue, 17 Mar 2020 06:58:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D77ED20724; Tue, 17 Mar 2020 10:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584442726; bh=UzxYSHzk2tW0gJ25zVESWN3tdPqPC6wHiWDbCCRoygE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g4aquv8i9TuTui3I1c3SceAL+vlPOfH8b6yEhPKbZAkb1Q0M6l37F2Nx636ZP9EmB 5znYyHAYRLDsGj3CUbU46ClzQ8zQgzel7nS5nl+cIdXMMs18/af418/kBma8Rut9io OrmPK239eggTYzf7MJm12SmmWxEqMiej2+YbN00E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro , stable@kernel.org Subject: [PATCH 4.19 59/89] gfs2_atomic_open(): fix O_EXCL|O_CREAT handling on cold dcache Date: Tue, 17 Mar 2020 11:55:08 +0100 Message-Id: <20200317103306.676904167@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103259.744774526@linuxfoundation.org> References: <20200317103259.744774526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Al Viro commit 21039132650281de06a169cbe8a0f7e5c578fd8b upstream. with the way fs/namei.c:do_last() had been done, ->atomic_open() instances needed to recognize the case when existing file got found with O_EXCL|O_CREAT, either by falling back to finish_no_open() or failing themselves. gfs2 one didn't. Fixes: 6d4ade986f9c (GFS2: Add atomic_open support) Cc: stable@kernel.org # v3.11 Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- fs/gfs2/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -1251,7 +1251,7 @@ static int gfs2_atomic_open(struct inode if (!(file->f_mode & FMODE_OPENED)) return finish_no_open(file, d); dput(d); - return 0; + return excl && (flags & O_CREAT) ? -EEXIST : 0; } BUG_ON(d != NULL);