FAILED: patch "[PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug" failed to apply to 5.5-stable tree

FAILED: patch "[PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug" failed to apply to 5.5-stable tree

[gregkh]

The patch below does not apply to the 5.5-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From f98371476f36359da2285d1807b43e5b17fd18de Mon Sep 17 00:00:00 2001
From: Linus Walleij <linus.walleij@linaro.org>
Date: Fri, 6 Mar 2020 15:34:15 +0100
Subject: [PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug

We are parsing SSBI gpios as fourcell fwspecs but they are
twocell. Probably a simple copy-and-paste bug.

Tested on the APQ8060 DragonBoard and after this ethernet
and MMC card detection works again.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: stable@vger.kernel.org
Reviewed-by: Brian Masney <masneyb@onstation.org>
Fixes: ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
Link: https://lore.kernel.org/r/20200306143416.1476250-1-linus.walleij@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
index fba1d41d20ec..338a15d08629 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
@@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
 	girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);
 	girq->parent_domain = parent_domain;
 	girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;
-	girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
+	girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;
 	girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;
 	girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;
 

Re: FAILED: patch "[PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug" failed to apply to 5.5-stable tree

[Sasha Levin]

On Mon, Mar 16, 2020 at 12:34:23PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.5-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From f98371476f36359da2285d1807b43e5b17fd18de Mon Sep 17 00:00:00 2001
>From: Linus Walleij <linus.walleij@linaro.org>
>Date: Fri, 6 Mar 2020 15:34:15 +0100
>Subject: [PATCH] pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug
>
>We are parsing SSBI gpios as fourcell fwspecs but they are
>twocell. Probably a simple copy-and-paste bug.
>
>Tested on the APQ8060 DragonBoard and after this ethernet
>and MMC card detection works again.
>
>Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>Cc: stable@vger.kernel.org
>Reviewed-by: Brian Masney <masneyb@onstation.org>
>Fixes: ae436fe81053 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
>Link: https://lore.kernel.org/r/20200306143416.1476250-1-linus.walleij@linaro.org
>Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I've also grabbed 242587616710 ("gpiolib: Add support for the irqdomain
which doesn't use irq_fwspec as arg") and queued both for 5.5.

-- 
Thanks,
Sasha