From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5102CC4332B for ; Thu, 19 Mar 2020 13:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C82420787 for ; Thu, 19 Mar 2020 13:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624717; bh=2vhibI530la2nXP38czFOi1Gon/TlBG9XWRRNIpIJCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zQiI20xsgzr6cPwdKpjZk0FMrHq5HDGDLAjglYoZDdg3XuTW5slGPZPN6QdMsJBwQ B0OR2U6XQzrZ3SBipv3wbaF7iEeFAAxgLx7JITqt4t7B9te1EecW1Ritiixzqz73Z2 ndcYW7jNPDleuAyuKe3803XZr5sA29a+ltnfA4yc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728437AbgCSNQy (ORCPT ); Thu, 19 Mar 2020 09:16:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:37528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728503AbgCSNQv (ORCPT ); Thu, 19 Mar 2020 09:16:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1715A21835; Thu, 19 Mar 2020 13:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623811; bh=2vhibI530la2nXP38czFOi1Gon/TlBG9XWRRNIpIJCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IJrmsX+2LYfFu0Gwa8blkupS1rV8nSrVPX8AznEZ8Mq8EgizxOCp8xfBKEwg7IiYA shpqMrLccn1cRKy/clDsDBBQSyhLirGVORRa93ZCSFCUsAG6+gMkbg81qucAmUyM2O 5gL6fe4C38Vz94BAENl/o6NLJn3Sorc3BOGrjfm4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lu Baolu , Zhenzhong Duan , Joerg Roedel Subject: [PATCH 4.14 61/99] iommu/vt-d: Fix the wrong printing in RHSA parsing Date: Thu, 19 Mar 2020 14:03:39 +0100 Message-Id: <20200319124000.098327497@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123941.630731708@linuxfoundation.org> References: <20200319123941.630731708@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhenzhong Duan commit b0bb0c22c4db623f2e7b1a471596fbf1c22c6dc5 upstream. When base address in RHSA structure doesn't match base address in each DRHD structure, the base address in last DRHD is printed out. This doesn't make sense when there are multiple DRHD units, fix it by printing the buggy RHSA's base address. Signed-off-by: Lu Baolu Signed-off-by: Zhenzhong Duan Fixes: fd0c8894893cb ("intel-iommu: Set a more specific taint flag for invalid BIOS DMAR tables") Signed-off-by: Joerg Roedel Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iommu/dmar.c +++ b/drivers/iommu/dmar.c @@ -486,7 +486,7 @@ static int dmar_parse_one_rhsa(struct ac pr_warn(FW_BUG "Your BIOS is broken; RHSA refers to non-existent DMAR unit at %llx\n" "BIOS vendor: %s; Ver: %s; Product Version: %s\n", - drhd->reg_base_addr, + rhsa->base_address, dmi_get_system_info(DMI_BIOS_VENDOR), dmi_get_system_info(DMI_BIOS_VERSION), dmi_get_system_info(DMI_PRODUCT_VERSION));