From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC2FC43332 for ; Thu, 19 Mar 2020 13:31:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58B2D20787 for ; Thu, 19 Mar 2020 13:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624687; bh=eNzdRRHaJ0+IxpR/5W49HbKbaI2NcG1Qkrx0pmi9OB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=SJXXR9QJOK+P7ucAHyNG1FdFO23tFcJcvoqsvhiHQHpV70fe+xy6UUnP/LCBIMYkS UxL2ymwUIjYid7FaprJkP/SIsdtaH1wiBqE8sL2+ZBoIPk0jfiCeFuehENYBkPTcCS O4Sl+dbluvVDq+EwjCzDGx3/mHrOpKQaKCtKAleo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729765AbgCSNST (ORCPT ); Thu, 19 Mar 2020 09:18:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:40342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729760AbgCSNSR (ORCPT ); Thu, 19 Mar 2020 09:18:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0253D2166E; Thu, 19 Mar 2020 13:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623897; bh=eNzdRRHaJ0+IxpR/5W49HbKbaI2NcG1Qkrx0pmi9OB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eRkohjlWC0fnAgZXxCv9srkAZOG3Vtg18wPhmCE1ex7AY0dHgDB+smxy+T43SYoMg UUntbrOaeZp8ANLie1sdcJSRJKOf3YJwLaxpPMqKWvZcuAn1PZo79UceDtdWxZ8uO3 n/GqqjfWqbTU4aDcGj8N+sCazXfh58JotE51yzoQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Madhuparna Bhowmik , Johannes Berg , Sasha Levin Subject: [PATCH 4.14 90/99] mac80211: rx: avoid RCU list traversal under mutex Date: Thu, 19 Mar 2020 14:04:08 +0100 Message-Id: <20200319124006.828986374@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123941.630731708@linuxfoundation.org> References: <20200319123941.630731708@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Madhuparna Bhowmik [ Upstream commit 253216ffb2a002a682c6f68bd3adff5b98b71de8 ] local->sta_mtx is held in __ieee80211_check_fast_rx_iface(). No need to use list_for_each_entry_rcu() as it also requires a cond argument to avoid false lockdep warnings when not used in RCU read-side section (with CONFIG_PROVE_RCU_LIST). Therefore use list_for_each_entry(); Signed-off-by: Madhuparna Bhowmik Link: https://lore.kernel.org/r/20200223143302.15390-1-madhuparnabhowmik10@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 31000622376df..7c92b1471c34c 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3862,7 +3862,7 @@ void __ieee80211_check_fast_rx_iface(struct ieee80211_sub_if_data *sdata) lockdep_assert_held(&local->sta_mtx); - list_for_each_entry_rcu(sta, &local->sta_list, list) { + list_for_each_entry(sta, &local->sta_list, list) { if (sdata != sta->sdata && (!sta->sdata->bss || sta->sdata->bss != sdata->bss)) continue; -- 2.20.1