Re: [PATCH 4.19 00/48] 4.19.112-rc1 review

[Sasha Levin <sashal@kernel.org>]

On Fri, Mar 20, 2020 at 09:03:17AM +0100, Greg Kroah-Hartman wrote:
>On Thu, Mar 19, 2020 at 08:00:32PM +0000, Ben Hutchings wrote:
>> On Fri, 2020-03-20 at 01:12 +0530, Naresh Kamboju wrote:
>> > On Thu, 19 Mar 2020 at 18:50, Greg Kroah-Hartman
>> > <gregkh@linuxfoundation.org> wrote:
>> > > This is the start of the stable review cycle for the 4.19.112 release.
>> > > There are 48 patches in this series, all will be posted as a response
>> > > to this one.  If anyone has any issues with these being applied, please
>> > > let me know.
>> > >
>> > > Responses should be made by Sat, 21 Mar 2020 12:37:04 +0000.
>> > > Anything received after that time might be too late.
>> > >
>> > > The whole patch series can be found in one patch at:
>> > >         https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.112-rc1.gz
>> > > or in the git tree and branch at:
>> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>> > > and the diffstat can be found below.
>> > >
>> > > thanks,
>> > >
>> > > greg k-h
>> > >
>> > > Faiz Abbas <faiz_abbas@ti.com>
>> > >     mmc: sdhci-omap: Fix Tuning procedure for temperatures < -20C
>> > >
>> > > Faiz Abbas <faiz_abbas@ti.com>
>> > >     mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning
>> >
>> > Results from Linaro’s test farm.
>> > No regressions on arm64, arm, x86_64, and i386.
>> >
>> > NOTE:
>> > The arm beagleboard x15 device running stable rc 4.19.112-rc1, 5.4.27-rc1
>> > and 5.5.11-rc2 kernel pops up the following messages on console log,
>> > Is this a problem ?
>> >
>> > [   15.737765] mmc1: unspecified timeout for CMD6 - use generic
>> > [   16.754248] mmc1: unspecified timeout for CMD6 - use generic
>> > [   16.842071] mmc1: unspecified timeout for CMD6 - use generic
>> > ...
>> > [  977.126652] mmc1: unspecified timeout for CMD6 - use generic
>> > [  985.449798] mmc1: unspecified timeout for CMD6 - use generic
>> [...]
>>
>> This warning was introduced by commit 533a6cfe08f9 "mmc: core: Default
>> to generic_cmd6_time as timeout in __mmc_switch()".  That should not be
>> applied to stable branches; it is not valid without (at least) these
>> preparatory changes:
>>
>> 0c204979c691 mmc: core: Cleanup BKOPS support
>> 24ed3bd01d6a mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC
>> ad91619aa9d7 mmc: block: Use generic_cmd6_time when modifying INAND_CMD38_ARG_EXT_CSD
>
>Ok, I've now dropped that patch, which also required me to drop
>1292e3efb149 ("mmc: core: Allow host controllers to require R1B for
>CMD6").  I've done so for 5.5.y, 5.4.y, and 4.19.y.

Should we instead take those preparatory changes, and 1292e3efb149?

-- 
Thanks,
Sasha