From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Simon Shields <simon@lineageos.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensor's bus
Date: Fri, 27 Mar 2020 13:28:28 +0100 [thread overview]
Message-ID: <20200327122828.GF7233@kozik-lap> (raw)
In-Reply-To: <20200326142037.20418-1-m.szyprowski@samsung.com>
On Thu, Mar 26, 2020 at 03:20:37PM +0100, Marek Szyprowski wrote:
> GPIO lines for the CM36651 sensor I2C bus use the normal not the inverted
> polarity. This bug has been there since adding the CM36651 sensor by
> commit 85cb4e0bd2294, but went unnoticed because the "i2c-gpio" driver
> ignored the GPIO polarity specified in the device-tree.
>
> The recent conversion of "i2c-gpio" driver to the new, descriptor based
> GPIO API, automatically made it the DT-specified polarity aware, what
> broke the CM36651 sensor operation.
>
> Fixes: c769eaf7a85d ("ARM: dts: exynos: Split Trats2 DTS in preparation for Midas boards")
> Fixes: c10d3290cbde ("ARM: dts: Use GPIO constants for flags cells in exynos4412 boards")
> Fixes: 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2")
Thanks, applied. I kept only last Fixes as this is the original error.
All later were just refactorings of the same bug.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-03-27 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200326142048eucas1p29aee56575f8b530fc2d83860f6185d6b@eucas1p2.samsung.com>
2020-03-26 14:20 ` [PATCH] ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensor's bus Marek Szyprowski
2020-03-27 12:28 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327122828.GF7233@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=simon@lineageos.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).