stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sultan Alsawaf <sultan@kerneltoast.com>
To: stable@vger.kernel.org
Cc: Sultan Alsawaf <sultan@kerneltoast.com>
Subject: [PATCH 1/2] drm/i915: Disable Panel Self Refresh (PSR) by default
Date: Sun, 29 Mar 2020 20:30:56 -0700	[thread overview]
Message-ID: <20200330033057.2629052-2-sultan@kerneltoast.com> (raw)
In-Reply-To: <20200330033057.2629052-1-sultan@kerneltoast.com>

From: Sultan Alsawaf <sultan@kerneltoast.com>

On all Dell laptops with panels and chipsets that support PSR (an
esoteric power-saving mechanism), both PSR1 and PSR2 cause flickering
and graphical glitches, sometimes to the point of making the laptop
unusable. Many laptops don't support PSR so it isn't known if PSR works
correctly on any consumer hardware as of 5.4. PSR was enabled by default
in 5.0 for capable hardware, so this patch just restores the previous
functionality of PSR being disabled by default.

More info is available on the freedesktop bug:
https://gitlab.freedesktop.org/drm/intel/issues/425

Cc: <stable@vger.kernel.org> # 5.4.x
Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
---
 drivers/gpu/drm/i915/i915_params.c | 3 +--
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 296452f9efe4..4a0d37f7cf49 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -84,8 +84,7 @@ i915_param_named_unsafe(enable_hangcheck, bool, 0600,
 
 i915_param_named_unsafe(enable_psr, int, 0600,
 	"Enable PSR "
-	"(0=disabled, 1=enabled) "
-	"Default: -1 (use per-chip default)");
+	"(-1=use per-chip default, 0=disabled [default], 1=enabled) ");
 
 i915_param_named_unsafe(force_probe, charp, 0400,
 	"Force probe the driver for specified devices. "
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index d29ade3b7de6..715888811593 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -50,7 +50,7 @@ struct drm_printer;
 	param(int, vbt_sdvo_panel_type, -1) \
 	param(int, enable_dc, -1) \
 	param(int, enable_fbc, -1) \
-	param(int, enable_psr, -1) \
+	param(int, enable_psr, 0) \
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-- 
2.26.0


  reply	other threads:[~2020-03-30  3:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30  3:30 [PATCH 0/2] A couple of important fixes for i915 on 5.4 Sultan Alsawaf
2020-03-30  3:30 ` Sultan Alsawaf [this message]
2020-03-30  8:51   ` [PATCH 1/2] drm/i915: Disable Panel Self Refresh (PSR) by default Greg KH
2020-03-30 15:50     ` Sultan Alsawaf
2020-03-30  3:30 ` [PATCH 2/2] drm/i915/gt: Schedule request retirement when timeline idles Sultan Alsawaf
2020-03-30 15:56   ` Sultan Alsawaf
2020-03-30 16:27   ` Chris Wilson
2020-03-30 16:35     ` Sultan Alsawaf
2020-03-30 16:45       ` Chris Wilson
2020-04-07 20:28         ` Sultan Alsawaf
2020-04-07 20:43           ` [PATCH v2] " Sultan Alsawaf
2020-04-12  7:48             ` Sultan Alsawaf
2020-04-12  7:56               ` Greg KH
2020-04-13 14:37                 ` Salvatore Bonaccorso
2020-04-13 15:23                 ` Sultan Alsawaf
2020-04-13 15:29                   ` [PATCH v3] " Sultan Alsawaf
2020-04-17  9:38                     ` Sultan Alsawaf
2020-04-18 10:29                       ` Greg KH
2020-04-18 10:30                     ` Greg KH
2020-03-30  8:51 ` [PATCH 0/2] A couple of important fixes for i915 on 5.4 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330033057.2629052-2-sultan@kerneltoast.com \
    --to=sultan@kerneltoast.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).