From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A23C2BA2B for ; Tue, 7 Apr 2020 00:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B01552082D for ; Tue, 7 Apr 2020 00:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586217813; bh=mh6KviTIlJ5Yfq+GJHAkUOq84+76MdnD8KTn8MMt++w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LdqjTW1Og338bFQCQ80/JW+mrr7iBpEQBIwzVSfm70qWtpN8MgHqB04T7s+jGWXHA wnNVUTHqNIhvubnIeZxFQ1m6YvEsBal175o3IeoGPPbMCve/f1w3HvMj0JKrohjac9 USUN109kj0bnhIDhHO862Qk8rKWenpDTAbUbDZeg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbgDGAD2 (ORCPT ); Mon, 6 Apr 2020 20:03:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:38662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728377AbgDGADR (ORCPT ); Mon, 6 Apr 2020 20:03:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 675B820842; Tue, 7 Apr 2020 00:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586217797; bh=mh6KviTIlJ5Yfq+GJHAkUOq84+76MdnD8KTn8MMt++w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bOzbVWhG0LRgPLEBfiepVvYQ5YpvTG7b17UyR2ArEUGdEqyMMoQLo5ZMT01EmjNqS OXtvhk1rm71S20QImXY/b27n9VWyHOyzfKnLJ3ZB50zVZyYv1uJhZBLhRJo2Anz9q+ 8nH/4TCFceqhffYp9iLpEWVmWZ4xCF71YJqWOvrU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xu Wang , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 3/4] qlcnic: Fix bad kzalloc null test Date: Mon, 6 Apr 2020 20:03:11 -0400 Message-Id: <20200407000312.17447-3-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200407000312.17447-1-sashal@kernel.org> References: <20200407000312.17447-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Xu Wang [ Upstream commit bcaeb886ade124331a6f3a5cef34a3f1484c0a03 ] In qlcnic_83xx_get_reset_instruction_template, the variable of null test is bad, so correct it. Signed-off-by: Xu Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c index 26263a192a77e..083aeca77c758 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c @@ -1724,7 +1724,7 @@ static int qlcnic_83xx_get_reset_instruction_template(struct qlcnic_adapter *p_d ahw->reset.seq_error = 0; ahw->reset.buff = kzalloc(QLC_83XX_RESTART_TEMPLATE_SIZE, GFP_KERNEL); - if (p_dev->ahw->reset.buff == NULL) + if (ahw->reset.buff == NULL) return -ENOMEM; p_buff = p_dev->ahw->reset.buff; -- 2.20.1