From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD91C2BB86 for ; Fri, 10 Apr 2020 03:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75C32217D8 for ; Fri, 10 Apr 2020 03:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586491147; bh=6rR/D0oBNBWDmy2WhKGvwDeXD2XTa6keYJkr0YYAIDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HJAn6b3DE1fBDyXAr/1PbdzuGmh90QqTTRfLF9Xr42UAcfYyHTHL5m0AbQa49tIkD tSOh+Qr/LBTFdjvvaIAw/g4NqgciggKsBrYU/4wlinMAHRaJU7yjvnhLNt7Lws+PRE Z+ChK804YrhuKB/lhojh7pvHLHfpt19HLQtlEngo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728211AbgDJDsd (ORCPT ); Thu, 9 Apr 2020 23:48:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:60138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728201AbgDJDsc (ORCPT ); Thu, 9 Apr 2020 23:48:32 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BC4721473; Fri, 10 Apr 2020 03:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586490513; bh=6rR/D0oBNBWDmy2WhKGvwDeXD2XTa6keYJkr0YYAIDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JBS2VAZWdZ0rONomENr8GHTI8Us5XK6fQKj/6o9yLJuqfK0jrZRZ2y1sr/gPPRlJu HtJtYof6xMTaAiJeNJVKLp9EjbtCQTflp6rh7dymocpUdLzaOIveldxDrUwxCQmDQg rr3aRFpsmkdRf8hu1FAy+QJOmZ83W30PuhL0tnLk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tao Zhou , Peter Zijlstra , Vincent Guittot , Mel Gorman , Sasha Levin Subject: [PATCH AUTOSEL 5.5 27/56] sched/fair: Fix condition of avg_load calculation Date: Thu, 9 Apr 2020 23:47:31 -0400 Message-Id: <20200410034800.8381-27-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200410034800.8381-1-sashal@kernel.org> References: <20200410034800.8381-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tao Zhou [ Upstream commit 6c8116c914b65be5e4d6f66d69c8142eb0648c22 ] In update_sg_wakeup_stats(), the comment says: Computing avg_load makes sense only when group is fully busy or overloaded. But, the code below this comment does not check like this. >From reading the code about avg_load in other functions, I confirm that avg_load should be calculated in fully busy or overloaded case. The comment is correct and the checking condition is wrong. So, change that condition. Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()") Signed-off-by: Tao Zhou Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Vincent Guittot Acked-by: Mel Gorman Link: https://lkml.kernel.org/r/Message-ID: Signed-off-by: Sasha Levin --- kernel/sched/fair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0ff2f43ac9cd7..1f5ea23c752be 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8323,7 +8323,8 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd, * Computing avg_load makes sense only when group is fully busy or * overloaded */ - if (sgs->group_type < group_fully_busy) + if (sgs->group_type == group_fully_busy || + sgs->group_type == group_overloaded) sgs->avg_load = (sgs->group_load * SCHED_CAPACITY_SCALE) / sgs->group_capacity; } -- 2.20.1