From: Greg KH <gregkh@linuxfoundation.org>
To: Giuliano Procida <gprocida@google.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/4] block: more locking around delayed work
Date: Fri, 10 Apr 2020 11:03:39 +0200 [thread overview]
Message-ID: <20200410090339.GA1691838@kroah.com> (raw)
In-Reply-To: <20200407165539.161505-2-gprocida@google.com>
On Tue, Apr 07, 2020 at 05:55:36PM +0100, Giuliano Procida wrote:
> commit 287922eb0b186e2a5bf54fdd04b734c25c90035c upstream.
>
> The upstream commit (block: defer timeouts to a workqueue) included
> various locking changes. The original commit message did not say
> anything about the extra locking. Perhaps this is only needed for
> workqueue callbacks and not timer callbacks. We assume it is needed
> here.
>
> This patch includes the locking changes but leaves timeouts using a
> timer.
>
> Both blk_mq_rq_timer and blk_rq_timed_out_timer will return without
> without doing any work if they cannot acquire the queue (without
> waiting).
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Don't write your own changelog text for something that is upstream,
include the original and then add your own later on below, making it
obvious what you are doing differently from the original commit.
And be sure to cc: all of the original people on that commit, and keep
their s-o-b also.
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-10 9:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 17:47 backport request for use-after-free blk_mq_queue_tag_busy_iter Giuliano Procida
2020-04-01 17:55 ` Greg KH
2020-04-03 9:20 ` Greg KH
2020-04-03 22:30 ` Giuliano Procida
2020-04-07 16:31 ` Giuliano Procida
2020-04-07 16:55 ` [PATCH 0/4] " Giuliano Procida
2020-04-10 9:04 ` Greg KH
2020-04-07 16:55 ` [PATCH 1/4] block: more locking around delayed work Giuliano Procida
2020-04-10 9:03 ` Greg KH [this message]
2020-04-15 12:03 ` Giuliano Procida
2020-04-07 16:55 ` [PATCH 2/4] blk-mq: Allow timeouts to run while queue is freezing Giuliano Procida
2020-04-07 16:55 ` [PATCH 3/4] blk-mq: sync things with blk_mq_queue_tag_busy_iter Giuliano Procida
2020-04-07 16:55 ` [PATCH 4/4] blk-mq: Allow blocking queue tag iter callbacks Giuliano Procida
2020-04-07 21:02 ` backport request for use-after-free blk_mq_queue_tag_busy_iter Giuliano Procida
2020-04-15 13:00 ` [PATCH v2 0/4] " Giuliano Procida
2020-05-18 7:27 ` Greg KH
2020-04-15 13:00 ` [PATCH v2 1/4] block: more locking around delayed work Giuliano Procida
2020-04-15 13:00 ` [PATCH v2 2/4] blk-mq: Allow timeouts to run while queue is freezing Giuliano Procida
2020-04-15 13:00 ` [PATCH v2 3/4] blk-mq: sync the update nr_hw_queues with blk_mq_queue_tag_busy_iter Giuliano Procida
2020-04-15 13:00 ` [PATCH v2 4/4] blk-mq: Allow blocking queue tag iter callbacks Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410090339.GA1691838@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gprocida@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).